Convert in-depth topics to use gjs #2127
Conversation
✅ Deploy Preview for ember-guides ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| ```gjs {data-filename=app/components/super-form.gjs} | ||
| import SuperInput from './super-input.gjs'; | ||
| import SuperTextarea from './super-input.gjs'; | ||
| import SuperSubmit from './super-input.gjs'; | ||
|
|
There was a problem hiding this comment.
Need to import hash and component helpers.
There was a problem hiding this comment.
Why's this resolved? I don't see the imports added to the example
There was a problem hiding this comment.
Ah, I see I forgot hash. According to @NullVoxPopuli the others are keywords and don't need to imported.
There was a problem hiding this comment.
hash will one day be built in, but that's not soon unless I find some dedicated time to learn how to do it. The last blocker for it was just cleared this week (now it's just me + time)
| import SuperSubmit from './super-input.gjs'; | ||
| import superIsValid from '../helpers/super-is-valid.js'; | ||
| import superErrorFor from '../helpers/super-error-for.js'; | ||
| import superAutoResize from '../modifiers/super-auto-resize.js'; | ||
|
|
There was a problem hiding this comment.
Need to import hash, helper, modifier, and component helpers.
|
Some of the built-in imports are documented here: https://guides.emberjs.com/release/components/template-tag-format/#toc_importing-built-ins |
But not 'component' or 'helper' or 'modifier'. |
ya, these are built-in keywords |
Oh, nice. I can just delete those TODO placeholders. |
…elpers as keywords
|
Would be great to also have those documented as built-in keyword on the template tag page! |
- no extensions - no relative paths
| {{yield (hash key=(theHelper) key2=(theHelper with args)) }} | ||
| ```gjs | ||
| <template> | ||
| {{yield (hash key=(theHelper) key2=(theHelper with args)) }} |
There was a problem hiding this comment.
import { hash } from '@ember/helper';
This PR updates the 4 markdown files in the Core Concepts / In-Depth Topics to use gjs.
I tried to limit the changes here to only migrating from
js+hbstogjs. In a few places, some reordering of the prose around the code snippets was unavoidable. Based on the number of changes, I'd recommend going through the rendered docs and see if anything looks awry.Some notes:
gjsrequires explicit imports, I added imports for things likeInputandmodifier. But I don't know the imports for thecomponenthelper andhelperhelper, so those should be addressed.autotracking-in-depth, some of the snippets now have diff indicators where they didn't before.rendering-values, everything that was justhandlebarshas been wrapped in<template></template>in agjsblock. Many of these care incomplete however, because they reference stuff that is not in scope. I think this is fine, but maybe somebody else has an opinion on a better way to handle these.Leaving as a draft until I figure out the imports.