Skip to content

fix: Remove @ember/string dependency#147

Merged
NullVoxPopuli merged 2 commits intoember-polyfills:mainfrom
MichalBryxi:mb/146-remove-dependency-on-ember-string
May 6, 2025
Merged

fix: Remove @ember/string dependency#147
NullVoxPopuli merged 2 commits intoember-polyfills:mainfrom
MichalBryxi:mb/146-remove-dependency-on-ember-string

Conversation

@MichalBryxi
Copy link
Copy Markdown
Contributor

@MichalBryxi MichalBryxi commented May 3, 2025

@MichalBryxi
Copy link
Copy Markdown
Contributor Author

MichalBryxi commented May 3, 2025 •
edited
Loading

This is just me trying to see if I can ease the pain adjecent to@ember/string v3 vs v4

cc: @NullVoxPopuli

@MichalBryxi
Copy link
Copy Markdown
Contributor Author

MichalBryxi commented May 3, 2025 •
edited
Loading

Hope is that it can ease some of the cases similar to: emberjs/ember-string#447

@MichalBryxi
fix: remove emberstring dependency
f628a97 
- Not needed / used anywhere
- Fixes ember-polyfills#146
@MichalBryxi MichalBryxi force-pushed the mb/146-remove-dependency-on-ember-string branch from 3050828 to f628a97 Compare May 3, 2025 15:49
@MichalBryxi
Copy link
Copy Markdown
Contributor Author

MichalBryxi commented May 6, 2025 •
edited
Loading

He? Ci is angry with:

Tooling
Missing download info for actions/cache@v2

Download immutable action package 'actions/checkout@v2'
Version: 2.7.0
Digest: sha256:95d28907bc868c0bab52f05f1f84cf8416c9415fba4c92519bc0b83bdce1eae3
Source commit SHA: ee0669bd1cc54295c223e0bb666b733df41de1c5
Download action repository 'volta-cli/action@v1' (SHA:efb293bee52c8749b10ecda410b3a3c441fe94d8)
Error: Missing download info for actions/cache@v2

@MichalBryxi
chore: Bump github actions dependencies
f2db859 
CI is currently angry with:

```
Download action repository 'volta-cli/action@v1' (SHA:efb293bee52c8749b10ecda410b3a3c441fe94d8)
Error: Missing download info for actions/cache@v2
```
@MichalBryxi
Copy link
Copy Markdown
Contributor Author

MichalBryxi commented May 6, 2025

Tried to (blindly) push update of actions/checkout and volta-cli/action. Let's see if it helps...

@NullVoxPopuli NullVoxPopuli merged commit e39597c into ember-polyfills:main May 6, 2025
2 of 4 checks passed
@NullVoxPopuli
Copy link
Copy Markdown
Collaborator

NullVoxPopuli commented May 6, 2025

I just merged anyway -- the change is safe, and CI/Volta are broken -- will fix in a bit

@github-actions github-actions bot mentioned this pull request May 6, 2025
Merged
@NullVoxPopuli NullVoxPopuli added the bug Something isn't working label May 6, 2025
@MichalBryxi MichalBryxi deleted the mb/146-remove-dependency-on-ember-string branch May 7, 2025 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Is @ember/string dependency needed?

2 participants

@MichalBryxi @NullVoxPopuli