Skip to content

Fix typescript-eslint v8 compatibility in test configs #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 3 commits into from
Closed

Fix typescript-eslint v8 compatibility in test configs #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c214a08
Initial plan
Copilot Nov 12, 2025
0bd487e
Fix typescript-eslint config to work with ember-eslint-parser
Copilot Nov 12, 2025
15462c1
Restore version detection logic - fix v8 compatibility
Copilot Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions test-projects/configs/flat-ts/eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@ import ts from 'typescript-eslint';

import { createRequire } from 'node:module';
const require = createRequire(import.meta.url);
const manifestPath = require.resolve('@typescript-eslint/parser/package.json');
const manifestPath = require.resolve('typescript-eslint/package.json');
const manifest = require(manifestPath);
const isV8 = manifest.version[0] > 8;
const isV8 = parseInt(manifest.version[0]) >= 8;

const parserOptions = {
esm: {
Expand All @@ -34,8 +34,7 @@ const parserOptions = {
ecmaVersion: 'latest',
},
ts: {
projectService: true,
...(isV8 ? {} : { project: true }),
...(isV8 ? { project: true } : { projectService: true, project: true }),
tsconfigRootDir: import.meta.dirname,
},
},
Expand Down
Empty file added test-projects/configs/flat-ts/unpublished-development-types/.gitkeep
View file
Open in desktop
Empty file.
4 changes: 2 additions & 2 deletions test-projects/gjs-types/.eslintrc.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ const manifestPath = require.resolve('@typescript-eslint/parser/package.json');
const manifest = require(manifestPath);
const isV8 = parseInt(manifest.version[0]) >= 8;

if (isV8) {
delete parserOptions.project;
if (isV8 && parserOptions.projectService) {
delete parserOptions.projectService;
}

module.exports = {
Expand Down
Loading