Skip to content

Use broader template-lint range #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lifeart merged 13 commits into from
Nov 27, 2024
Merged

Use broader template-lint range #418

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
035923e
Update template-linter.ts
NullVoxPopuli Nov 22, 2024
514ae2f
Do a proper comparison
NullVoxPopuli Nov 22, 2024
1859807
Add comment explaining semver.parse
NullVoxPopuli Nov 22, 2024
2dd183c
Don't clean at all -- turns out template-lint is the only thing that …
NullVoxPopuli Nov 22, 2024
827faef
Remove unused import
lifeart Nov 25, 2024
10a09db
import type
lifeart Nov 25, 2024
e2804b1
add failing test
lifeart Nov 25, 2024
5e964ca
+
lifeart Nov 25, 2024
372197b
+
lifeart Nov 25, 2024
95e33c8
use dependenciesMeta for template-lint version
lifeart Nov 25, 2024
8b30ec5
do not lint if no meta for template-lint
lifeart Nov 25, 2024
e44d324
remove unused logic
lifeart Nov 25, 2024
45158a0
update tests
lifeart Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/template-linter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ export default class TemplateLinter {

// we assume that ember-template-lint v5 could handle js/ts/gts/gjs files

if (templateLintVersion === '5') {
if (templateLintVersion >= '5') {
return [documentContent];
}
Copy link

@arthur5005 arthur5005 Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NullVoxPopuli this isn't enough I don't believe, the templateLintVersion might come in as a ^ or a ~

Copy link
Member Author

@NullVoxPopuli NullVoxPopuli Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent point -- I'll update this to use semver

Copy link
Contributor

@lifeart lifeart Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NullVoxPopuli we need parseInt here :)

Copy link
Member Author

@NullVoxPopuli NullVoxPopuli Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not if it's a ^ -- gonna use the semver package. sorry for the low effort initial PR!

Copy link
Contributor

@lifeart lifeart Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NullVoxPopuli it's not a case - we have this precondition - https://github.com/ember-tooling/ember-language-server/blob/master/src/utils/layout-helpers.ts#L293


Expand Down