do not default moduleName to fileName #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

patricklx wants to merge 1 commit into emberjs:main from patricklx:patch-1

Contributor

patricklx commented Jul 27, 2023 •

edited

Loading

relevant issue: emberjs/ember-inspector#2425


          do not default moduleName to fileName

13ba406

Contributor

ef4 commented Jul 27, 2023

This is probably a good change but needs to be part of a wider transition plan. This would be a breaking change for AST transforms, for example.

Let's discuss in the context of emberjs/rfcs#940.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet