Open
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Removed all node_modules and lockfiles, ran fresh pnpm install - Updated volta node config from 18.20.4 to 24.14.0 - Updated node-version in publish.yml and plan-release.yml from 18 to 24 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Fix tsconfig: add declaration: true (required by newer TS with declarationDir) - Add prepare script to root to build addon during pnpm install - Update ember-cli to ~5.12.0, ember-source to ~5.12.0 in test-app - Update ember-auto-import to ^2.13.1 - Update @embroider/* packages, revert test-setup to ^3.0.3 (v4 pulls in @embroider/core which activates embroider pipeline via maybeEmbroider, breaking injected v2 addon resolution) - Add ember-cli ^6.10.0 to ember-try release/beta/canary scenarios - Add pnpm override for ember-cli-htmlbars ^7.0.1 - Re-roll all lockfiles Verified locally: lints pass (including lint:types), 552/553 tests pass (1 pre-existing flaky test about test-waiters version detection). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The test for getSettledState uses @embroider/macros dependencySatisfies to check the test-waiters version at build time. Without test-waiters as a direct dependency of the test-app, the macro can't resolve the version correctly, causing the hasPendingLegacyWaiters assertion to fail. Verified locally: all lints pass, 553/553 tests pass. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
With shared-workspace-lockfile=false, pnpm overrides in the root package.json don't propagate to workspace packages. Move the override into test-app/package.json so ember-tracked-storage-polyfill's transitive dep on ember-cli-htmlbars@5.7.2 gets resolved to ^7.0.1. Verified locally: all lints pass, 553/553 tests pass. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ember-resolver v10 imports from the 'ember' barrel which was removed in ember 7. Update to v13 which drops the classic resolver. Convert test-app's resolver from Resolver.extend() to a native class. Verified locally: lints pass, 553/553 tests pass. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ember-qunit v8 uses .extend() on @ember/test/adapter which is incompatible with ember 4.4. Pin to v7 for that scenario. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ember-qunit v9 no longer auto-calls loadTests() or setupEmberOnerrorValidation() from start(). Use macroCondition with dependencySatisfies to conditionally call these for v9+, so the test-helper works with both v8 (ember-try 4.4 scenario) and v9. Verified locally: lints pass, 553/553 tests pass. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Replace `inject as injectService` with `service as injectService` from @ember/service (inject was removed in ember 7) - Update @glimmer/component to ^2.0.0 (v1 imports from the ember barrel which was removed in ember 7) Verified locally: lints pass, 553/553 tests pass. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
NullVoxPopuli
force-pushed
the
ember-7-compat
branch
from
f7977ea to
a3b1150
Compare
Member
|
Collaborator
Author
I don't think so -- nothing about the addon actually changed. |
Collaborator
Author
|
we also don't do breaking changes for TS very frequently due to the rolling policy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Get CI working with ember 7
diif looks large, because this repo has multiple lockfiles
summary of changes