-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
[FEATURE] Publish stable types for Ember #20449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
105 commits
Select commit
Hold shift + click to select a range
90f78e7
Publish types from source and remove preview types
chriskrycho 06b7acb
Change how loader's `define` becomes visiblte to TS
chriskrycho 22a100b
Add ability to manually copy `.d.ts` type modules
chriskrycho 5da100d
Provide an `owner-ext` for `@ember/service`
chriskrycho 6551040
Import a root without `/index` in `ember-template-compiler`
chriskrycho e034e72
The router service presently takes a generic
chriskrycho 80b738d
Update how we compile backburner.js' types
chriskrycho c1f0073
Publishing script: do not wrap passthrough copies
chriskrycho 4e15f8b
Correct the `@ember/application` type test
chriskrycho edbb768
Do not special-case ember-template-compiler/lib/types
chriskrycho 3917d20
Use `keyof this` in `Observable`'s `get`, `set`, etc.
chriskrycho 3940d67
Emit named items for built-in components
chriskrycho 31cef6f
Correctly handle router registration into service registry
chriskrycho 632cb35
Name the return type of (internal) controllerFor
chriskrycho 6473757
Loosen restriction on service registry
chriskrycho 4408557
Substantially refactor `publish.mjs`
chriskrycho 6e1472e
Fix types and type tests for `@ember/array`
chriskrycho 6dedf8b
Correct `@ember/object` type tests given improved safety
chriskrycho ee42331
Update `@ember/application` type tests for DI registry
chriskrycho 5d2db7e
Handle type (un)safety of some runloop `bind`
chriskrycho e596002
Handle `declare namespace` in types publishing script
chriskrycho 2fdb3f5
Refactor `Ember` namespace to be a TS `namespace`
chriskrycho 7e5cc1a
Add top-level safe key list for `getProperties`
chriskrycho 6385cea
Provide a useful type for `@computed.meta()`
chriskrycho abc0c4e
Extract owner and location side effect modules for routing/location
chriskrycho d48f51e
Dramatically simplify routing types, fix its type tests
chriskrycho bdf9fcf
Make cache-for slightly type-safer
chriskrycho 436d583
Update types and tests for Ember namespace
chriskrycho 229eb14
Remove extraneous type parameter from ArrayProxy
chriskrycho afa3d97
Make the `compare` utility more type safe
chriskrycho 9f293e5
Correctly capture the overload semantics of `warn`
chriskrycho ccb1afa
Fix type errors (by using simpler types!) for utils
chriskrycho 09f3b36
Fix types and type tests for `@ember/debug/data-adapter`
chriskrycho cd91172
Update type tests to match RouterService implementation
chriskrycho 5649f39
Fix types and type tests for @ember/debug
chriskrycho c203349
Improve local types for component-managers
chriskrycho 1d2e048
Fix types for `assert` and `(get|set)DebugFunction`
chriskrycho 23da1ea
Explicitly name an indexed type in router.ts
chriskrycho 284ea81
Set correct types for QUnit test adapter
chriskrycho c9b410a
Allow `ember-testing`'s `Promise` not to have labels
chriskrycho fde1a80
Add a required `as const` for Controller QPs type test
chriskrycho 9923c7a
Supply correct internal types for `precompileTemplate`
chriskrycho 0c2058d
Handle edge case in types publishing path mapping
chriskrycho de0f67a
Update the Ember NS `debug` tests to match modules
chriskrycho 2a1dd3e
Update types and type tests for CP macros
chriskrycho 11f1ecf
Simplify types for `(get|set)Properties`
chriskrycho 5d87525
Account for optionality of `assertDestroyablesDestroyed`
chriskrycho a2e42e1
Eliminate cycle in definition of (Ember) `Component`
chriskrycho 341e356
Fix/simplify types of `create`, `reopen`, and `reopenClass`
chriskrycho f70771d
Update engine type tests now that types catch more errors
chriskrycho 284f6db
Remove now-defunct types for `(add|remove)Listener`
chriskrycho b3af348
Accept re-mappings in Controller QP type definitions
chriskrycho 35251ec
Remove extranes `extends` from `EmberObject` interface
chriskrycho 3b320c0
The type of `objectsAt` is `Array`, not `Ember.Array`
chriskrycho b94db2c
Handle optionality of `Ember.Test` in type tests
chriskrycho 294e401
Provide type safe get and set in ObjectProxy
chriskrycho dd37b6c
Use `Owner` correctly in `@ember/object` type tests
chriskrycho a17d279
Fix `@ember/object` tests for proxy and observable
chriskrycho 6694ed7
Fix bad import and reference in ember NS type tests
chriskrycho 86eeaf7
Partially reimplement type-safe `.create()`
chriskrycho 2fd539a
Correctly export both sides of the opaque LinkTo
chriskrycho dd907e9
Update a `set()` type test: it allows dynamic setting
chriskrycho 972a9e1
Remove a type test which only covered internals
chriskrycho ffb0501
Update type tests for improved `set`/`get` inference
chriskrycho 8d80667
Drop `Ember.get` from Ember Router tests
chriskrycho 26f16cb
Further remove generic Route param from router
chriskrycho caf4b1d
Fix types for internal-test-helpers
chriskrycho 4799725
Finish updating internals for safe-r create
chriskrycho be2596f
Improve correctness and usability of `@ember/modifier` types
chriskrycho cb8f6fd
Improve types and type tests for `@ember/test`
chriskrycho a0ab50f
Fix some missed type tests for `.extend`, `.create`, and `.reopen`
chriskrycho ad9e569
Correctly handle opaque LinkTo type in type tests
chriskrycho 142d5d1
Fix type test for Ember.Object: correct `Owner`
chriskrycho 06c3a14
Correct type tests for `typeOf` (just `string`)
chriskrycho 40722d2
Add `static positionalParams` type declaration to EmberComponent
chriskrycho ef18c84
Fix types of ArrayProxy.content
chriskrycho 08296c6
Fix types around component templates and TOCs
chriskrycho e57bc26
Fix types and type tests for `@ember/test`
chriskrycho 9d65d25
Drop an unused import from Ember type tests
chriskrycho 911e14c
Make Ember's helper types Glint-compatible
chriskrycho c0f010c
Fix optionality of `owner` arg for `Route` class
chriskrycho 5b397e1
Fix types for template-only components
chriskrycho 40b3a19
Fix re-export of `Ember.RSVP` as a `namespace`
chriskrycho 05acc98
Drop now-unnecessary `types/preview` from type-tests
chriskrycho 2f26a2c
Fix TS lint errors
chriskrycho 73dc0cd
Remove assertion from build-owner internal test helper
chriskrycho f55cc15
Fix a missed rename in `ember/index.ts`
chriskrycho 3f54dc7
Update Ember NS reexport test for backburner.js
chriskrycho 2f826a3
Add private runloop backburner re-exports
chriskrycho 544d381
Remove an unnecessary type cast from Router
chriskrycho 9fd1b03
Fix typo in comment in broccoli/packages.js
chriskrycho 2287751
Do not duplicate work on hand-written `.d.ts` files
chriskrycho 4bc5d73
Include signatures in Ember NS re-exports
chriskrycho 22276b5
Export built-in components as interfaces for Glint
chriskrycho b7a7a57
Mark internal `Route` details with `@internal`
chriskrycho ae6d85d
Fix typo in description of `Opaque`
chriskrycho 824a3b6
Fix typo in comment explaining abstract class for helper
chriskrycho e572863
Provide default type for Signatures etc. in Ember NS
chriskrycho 19b31a3
Explicitly type test fallback path for runloop `bind`
chriskrycho 1038406
Use `import type` in internal components
chriskrycho c725cdc
Publicly export `FunctionBasedHelperInstance`
chriskrycho f3fa810
Move `@glimmer/*` packages to `dependencies`
chriskrycho f0e501d
Move backburner.js and router_js to `dependencies`
chriskrycho 4827457
Move `route-recognizer` to `dependencies`
chriskrycho 164920b
Merge remote-tracking branch 'origin/main' into types-from-source
chriskrycho File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.