Skip to content

Allow importing form qunit directly -- Upgrading to qunit3 solves the problem where we couldn't import directly from qnuit #21050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NullVoxPopuli wants to merge 2 commits into from
Closed

Allow importing form qunit directly -- Upgrading to qunit3 solves the problem where we couldn't import directly from qnuit #21050

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2d8f80
Upgrading to qunit3 solves the problem where we couldn't import direc…
NullVoxPopuli Jan 7, 2026
9180f7b
Upgrade more qunit occurences
NullVoxPopuli Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion glimmer-vm/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

<body>
<script type="module">
import "qunit/qunit/qunit.js";
import "qunit";
import { runTests } from "@glimmer-workspace/integration-tests";
await runTests(
import.meta.glob("./packages/{@glimmer,@glimmer-workspace}/*/test/**/*-test.ts"),
Expand Down
2 changes: 1 addition & 1 deletion glimmer-vm/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@
"preval.macro": "^5.0.0",
"puppeteer": "24.11.2",
"puppeteer-chromium-resolver": "^24.0.1",
"qunit": "^2.24.1",
"qunit": "^3.0.0-alpha.4",
Copy link
Member

@kategengler kategengler Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about use using an alpha.

This alpha was published over a year ago and there have been no more since. Is it still the direction qunit will go? Will it progress or will they start over on a 3?

The latest 2.25 was within the last couple of weeks.

Copy link
Contributor Author

@NullVoxPopuli NullVoxPopuli Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

V3 is the only esm copy of qunit that exists.

I'll see what timo is up to

Copy link
Contributor Author

@NullVoxPopuli NullVoxPopuli Jan 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Timo said they're going to do a release candidate soon

"release-plan": "^0.13.1",
"rimraf": "^5.0.10",
"rollup": "^4.34.8",
Expand Down
4 changes: 3 additions & 1 deletion index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
</head>
<body>
<script type="module">
import 'qunit/qunit/qunit.js';
import 'qunit';
import 'qunit/qunit/qunit.css';

window.EmberENV = {};
Expand Down Expand Up @@ -80,6 +80,8 @@
import.meta.glob('./packages/{@glimmer,@glimmer-workspace}/*/test/**/*-test.{js,ts}', {
eager: true,
});

import.meta.glob('./tests/browser/**/*.{js,ts}', { eager: true });
</script>

<div id="qunit"></div>
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@
"node-gzip": "^1.1.2",
"npm-run-all2": "^6.0.6",
"prettier": "^3.5.3",
"qunit": "^2.19.4",
"qunit": "^3.0.0-alpha.4",
"recast": "^0.22.0",
"resolve.exports": "^2.0.3",
"rollup": "^4.2.0",
Expand Down Expand Up @@ -383,4 +383,4 @@
}
},
"packageManager": "[email protected]"
}
}
2 changes: 1 addition & 1 deletion packages/@glimmer-workspace/integration-tests/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"@simple-dom/serializer": "^1.4.0",
"@simple-dom/void-map": "^1.4.0",
"js-reporters": "^2.1.0",
"qunit": "^2.24.1",
"qunit": "^3.0.0-alpha.4",
"simple-html-tokenizer": "^0.5.11"
},
"devDependencies": {
Expand Down
31 changes: 27 additions & 4 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions tests/browser/qunit-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
import { module, test } from 'qunit';

module('Example', function () {
test('example test', function (assert) {
assert.ok('we did it');
});
});