Open
Conversation
… configuration - Added @handlebars/** to the list of exposed dependencies in rollup.config.mjs. - Updated the resolution path for @handlebars/parser in hiddenDependencies function. - Created a .gitignore file for the @handlebars/parser package to exclude dist/ and lib/parser.js.
NullVoxPopuli
force-pushed
the
nvp/bringin-handlebars-parser
branch
from
3128839 to
343836d
Compare
…hings we build in the root package.josn
Contributor
Estimated Asset SizesDiff --- main/out.txt 2026-02-10 19:32:04.000000000 +0000
+++ pr/./pr-21914152484/out.txt 2026-02-11 16:46:48.000000000 +0000
@@ -1,13 +1,13 @@
-╔═══════╤═══════════╤═══════════╗
-║ │ Min │ Gzip ║
-╟───────┼───────────┼───────────╢
-║ Total │ 352.02 KB │ 203.77 KB ║
-╚═══════╧═══════════╧═══════════╝
+╔═══════╤═══════════╤══════════╗
+║ │ Min │ Gzip ║
+╟───────┼───────────┼──────────╢
+║ Total │ 352.02 KB │ 203.8 KB ║
+╚═══════╧═══════════╧══════════╝
╔══════════════════════╤═══════════╤═══════════╗
║ @ember/* │ Min │ Gzip ║
╟──────────────────────┼───────────┼───────────╢
-║ Total │ 313.42 KB │ 181.95 KB ║
+║ Total │ 313.42 KB │ 181.98 KB ║
╟──────────────────────┼───────────┼───────────╢
║ -internals │ 36.65 KB │ 26.23 KB ║
║ application │ 13.23 KB │ 8.09 KB ║
@@ -30,7 +30,7 @@
║ service │ 1 KB │ 845 B ║
║ template │ 654 B │ 519 B ║
║ template-compilation │ 429 B │ 366 B ║
-║ template-compiler │ 123.08 KB │ 59.45 KB ║
+║ template-compiler │ 123.08 KB │ 59.48 KB ║
║ template-factory │ 370 B │ 374 B ║
║ test │ 923 B │ 627 B ║
║ utils │ 4.11 KB │ 3.6 KB ║Details
|
Contributor
Author
|
it gzipped better! that's intriguing |
NullVoxPopuli
commented
Feb 11, 2026
Contributor
Author
There was a problem hiding this comment.
Copied from the handlebars repo
NullVoxPopuli
commented
Feb 11, 2026
Contributor
Author
There was a problem hiding this comment.
Copied from the handlebars repo
NullVoxPopuli
commented
Feb 11, 2026
Contributor
Author
There was a problem hiding this comment.
Copied from the handlebars repo
NullVoxPopuli
commented
Feb 11, 2026
Contributor
Author
There was a problem hiding this comment.
Copied from the handlebars repo
NullVoxPopuli
commented
Feb 11, 2026
Contributor
Author
There was a problem hiding this comment.
Generated -- not in the handlebars repo, but is in the package. it was originally gitignored -- but it doesn't actually change that often so it's kinda easier to just have in git so that node/babel/whatever can access it during the build process
NullVoxPopuli
commented
Feb 11, 2026
Contributor
Author
There was a problem hiding this comment.
Copied from the handlebars repo
NullVoxPopuli
commented
Feb 11, 2026
Contributor
Author
There was a problem hiding this comment.
Copied from the handlebars repo
NullVoxPopuli
commented
Feb 11, 2026
Contributor
Author
There was a problem hiding this comment.
Copied from the handlebars repo
NullVoxPopuli
commented
Feb 11, 2026
Contributor
Author
There was a problem hiding this comment.
Copied from the handlebars repo
NullVoxPopuli
commented
Feb 11, 2026
Contributor
Author
There was a problem hiding this comment.
Copied from the handlebars repo
NullVoxPopuli
commented
Feb 11, 2026
Contributor
Author
There was a problem hiding this comment.
Copied from the handlebars repo
NullVoxPopuli
commented
Feb 11, 2026
Contributor
Author
There was a problem hiding this comment.
Copied from the handlebars repo
NullVoxPopuli
commented
Feb 11, 2026
Contributor
Author
There was a problem hiding this comment.
Copied from the handlebars repo
NullVoxPopuli
commented
Feb 11, 2026
Contributor
Author
There was a problem hiding this comment.
Copied from the handlebars repo
NullVoxPopuli
commented
Feb 11, 2026
Contributor
Author
There was a problem hiding this comment.
Copied from the handlebars repo
NullVoxPopuli
commented
Feb 11, 2026
Contributor
Author
There was a problem hiding this comment.
Copied from the handlebars repo
NullVoxPopuli
commented
Feb 11, 2026
Contributor
Author
There was a problem hiding this comment.
Copied from the handlebars repo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internalizes: https://github.com/handlebars-lang/handlebars-parser
@glimmer/syntaxcurrently has these dependencies:and we don't actually use handlebars, so bringing in the parser is a good opportunity to make the parser do exactly what we need, and not a thing more (removing hacks to work around handlebars behaviors we don't support), etc.
Additionally, the handlebars parser has support for things we don't support.
So we'll need to reconcile that at some point.
Important
This PR enables us to combine the glimmer/handlebars code so we don't have the unneeded separation / abstraction -- I suspect we will shed some kB after this happens as well