Fix private field access by NullVoxPopuli · Pull Request #21088 · emberjs/ember.js

NullVoxPopuli · 2026-02-11T22:24:30Z

runtime template()
- implicit scope
- explicit scope
  - mentioned here JS Representation of Template Tag rfcs#931
build time (normal usage)? (separate PR?)

github-actions · 2026-02-11T22:26:04Z

Estimated Asset Sizes

Diff

--- main/out.txt	2026-02-13 03:26:02.000000000 +0000
+++ pr/./pr-21973698792/out.txt	2026-02-13 03:39:00.000000000 +0000
@@ -1,46 +1,46 @@
 ╔═══════╤═══════════╤═══════════╗
 ║       │ Min       │ Gzip      ║
 ╟───────┼───────────┼───────────╢
-║ Total │ 352.02 KB │ 203.77 KB ║
+║ Total │ 353.01 KB │ 204.43 KB ║
 ╚═══════╧═══════════╧═══════════╝
 
-╔══════════════════════╤═══════════╤═══════════╗
-║ @ember/*             │ Min       │ Gzip      ║
-╟──────────────────────┼───────────┼───────────╢
-║ Total                │ 313.42 KB │ 181.95 KB ║
-╟──────────────────────┼───────────┼───────────╢
-║ -internals           │ 36.65 KB  │ 26.23 KB  ║
-║ application          │ 13.23 KB  │ 8.09 KB   ║
-║ array                │ 13.01 KB  │ 7.46 KB   ║
-║ canary-features      │ 304 B     │ 389 B     ║
-║ component            │ 2.05 KB   │ 1.64 KB   ║
-║ controller           │ 1.96 KB   │ 1.41 KB   ║
-║ debug                │ 11.69 KB  │ 8.12 KB   ║
-║ deprecated-features  │ 31 B      │ 77 B      ║
-║ destroyable          │ 561 B     │ 383 B     ║
-║ enumerable           │ 259 B     │ 387 B     ║
-║ helper               │ 1.08 KB   │ 803 B     ║
-║ instrumentation      │ 2.43 KB   │ 1.79 KB   ║
-║ modifier             │ 1.22 KB   │ 966 B     ║
-║ object               │ 35.94 KB  │ 22.16 KB  ║
-║ owner                │ 159 B     │ 178 B     ║
-║ renderer             │ 630 B     │ 492 B     ║
-║ routing              │ 59.33 KB  │ 34.13 KB  ║
-║ runloop              │ 2.36 KB   │ 1.5 KB    ║
-║ service              │ 1 KB      │ 845 B     ║
-║ template             │ 654 B     │ 519 B     ║
-║ template-compilation │ 429 B     │ 366 B     ║
-║ template-compiler    │ 123.08 KB │ 59.45 KB  ║
-║ template-factory     │ 370 B     │ 374 B     ║
-║ test                 │ 923 B     │ 627 B     ║
-║ utils                │ 4.11 KB   │ 3.6 KB    ║
-║ version              │ 55 B      │ 131 B     ║
-╚══════════════════════╧═══════════╧═══════════╝
+╔══════════════════════╤═══════════╤══════════╗
+║ @ember/*             │ Min       │ Gzip     ║
+╟──────────────────────┼───────────┼──────────╢
+║ Total                │ 314.41 KB │ 182.6 KB ║
+╟──────────────────────┼───────────┼──────────╢
+║ -internals           │ 36.65 KB  │ 26.03 KB ║
+║ application          │ 13.23 KB  │ 8.04 KB  ║
+║ array                │ 13.01 KB  │ 7.54 KB  ║
+║ canary-features      │ 304 B     │ 389 B    ║
+║ component            │ 2.05 KB   │ 1.62 KB  ║
+║ controller           │ 1.96 KB   │ 1.46 KB  ║
+║ debug                │ 11.69 KB  │ 8.12 KB  ║
+║ deprecated-features  │ 31 B      │ 77 B     ║
+║ destroyable          │ 561 B     │ 383 B    ║
+║ enumerable           │ 259 B     │ 387 B    ║
+║ helper               │ 1.08 KB   │ 844 B    ║
+║ instrumentation      │ 2.43 KB   │ 1.79 KB  ║
+║ modifier             │ 1.22 KB   │ 983 B    ║
+║ object               │ 35.94 KB  │ 22.23 KB ║
+║ owner                │ 159 B     │ 178 B    ║
+║ renderer             │ 630 B     │ 515 B    ║
+║ routing              │ 59.33 KB  │ 34.02 KB ║
+║ runloop              │ 2.36 KB   │ 1.46 KB  ║
+║ service              │ 1 KB      │ 872 B    ║
+║ template             │ 654 B     │ 551 B    ║
+║ template-compilation │ 429 B     │ 366 B    ║
+║ template-compiler    │ 124.07 KB │ 60.13 KB ║
+║ template-factory     │ 370 B     │ 374 B    ║
+║ test                 │ 923 B     │ 627 B    ║
+║ utils                │ 4.11 KB   │ 3.64 KB  ║
+║ version              │ 55 B      │ 131 B    ║
+╚══════════════════════╧═══════════╧══════════╝
 
 ╔═════════════════╤══════════╤══════════╗
 ║ @glimmer/*      │ Min      │ Gzip     ║
 ╟─────────────────┼──────────┼──────────╢
-║ Total           │ 38.6 KB  │ 21.82 KB ║
+║ Total           │ 38.6 KB  │ 21.83 KB ║
 ╟─────────────────┼──────────┼──────────╢
 ║ destroyable     │ 2.77 KB  │ 1.39 KB  ║
 ║ encoder         │ 81 B     │ 171 B    ║
@@ -53,7 +53,7 @@
 ║ program         │ 252 B    │ 301 B    ║
 ║ reference       │ 548 B    │ 531 B    ║
 ║ runtime         │ 10.32 KB │ 5.22 KB  ║
-║ tracking        │ 1.34 KB  │ 1.16 KB  ║
+║ tracking        │ 1.34 KB  │ 1.17 KB  ║
 ║ util            │ 1.94 KB  │ 1.68 KB  ║
 ║ validator       │ 15.75 KB │ 6.96 KB  ║
 ║ vm              │ 495 B    │ 569 B    ║

Details

This PR main

╔═══════╤═══════════╤═══════════╗
║       │ Min       │ Gzip      ║
╟───────┼───────────┼───────────╢
║ Total │ 353.01 KB │ 204.43 KB ║
╚═══════╧═══════════╧═══════════╝

╔══════════════════════╤═══════════╤══════════╗
║ @ember/*             │ Min       │ Gzip     ║
╟──────────────────────┼───────────┼──────────╢
║ Total                │ 314.41 KB │ 182.6 KB ║
╟──────────────────────┼───────────┼──────────╢
║ -internals           │ 36.65 KB  │ 26.03 KB ║
║ application          │ 13.23 KB  │ 8.04 KB  ║
║ array                │ 13.01 KB  │ 7.54 KB  ║
║ canary-features      │ 304 B     │ 389 B    ║
║ component            │ 2.05 KB   │ 1.62 KB  ║
║ controller           │ 1.96 KB   │ 1.46 KB  ║
║ debug                │ 11.69 KB  │ 8.12 KB  ║
║ deprecated-features  │ 31 B      │ 77 B     ║
║ destroyable          │ 561 B     │ 383 B    ║
║ enumerable           │ 259 B     │ 387 B    ║
║ helper               │ 1.08 KB   │ 844 B    ║
║ instrumentation      │ 2.43 KB   │ 1.79 KB  ║
║ modifier             │ 1.22 KB   │ 983 B    ║
║ object               │ 35.94 KB  │ 22.23 KB ║
║ owner                │ 159 B     │ 178 B    ║
║ renderer             │ 630 B     │ 515 B    ║
║ routing              │ 59.33 KB  │ 34.02 KB ║
║ runloop              │ 2.36 KB   │ 1.46 KB  ║
║ service              │ 1 KB      │ 872 B    ║
║ template             │ 654 B     │ 551 B    ║
║ template-compilation │ 429 B     │ 366 B    ║
║ template-compiler    │ 124.07 KB │ 60.13 KB ║
║ template-factory     │ 370 B     │ 374 B    ║
║ test                 │ 923 B     │ 627 B    ║
║ utils                │ 4.11 KB   │ 3.64 KB  ║
║ version              │ 55 B      │ 131 B    ║
╚══════════════════════╧═══════════╧══════════╝

╔═════════════════╤══════════╤══════════╗
║ @glimmer/*      │ Min      │ Gzip     ║
╟─────────────────┼──────────┼──────────╢
║ Total           │ 38.6 KB  │ 21.83 KB ║
╟─────────────────┼──────────┼──────────╢
║ destroyable     │ 2.77 KB  │ 1.39 KB  ║
║ encoder         │ 81 B     │ 171 B    ║
║ env             │ 38 B     │ 87 B     ║
║ global-context  │ 886 B    │ 545 B    ║
║ manager         │ 977 B    │ 608 B    ║
║ node            │ 175 B    │ 245 B    ║
║ opcode-compiler │ 1.11 KB  │ 894 B    ║
║ owner           │ 159 B    │ 202 B    ║
║ program         │ 252 B    │ 301 B    ║
║ reference       │ 548 B    │ 531 B    ║
║ runtime         │ 10.32 KB │ 5.22 KB  ║
║ tracking        │ 1.34 KB  │ 1.17 KB  ║
║ util            │ 1.94 KB  │ 1.68 KB  ║
║ validator       │ 15.75 KB │ 6.96 KB  ║
║ vm              │ 495 B    │ 569 B    ║
║ wire-format     │ 1.84 KB  │ 1.35 KB  ║
╚═════════════════╧══════════╧══════════╝

╔═══════╤═══════════╤═══════════╗
║       │ Min       │ Gzip      ║
╟───────┼───────────┼───────────╢
║ Total │ 352.02 KB │ 203.77 KB ║
╚═══════╧═══════════╧═══════════╝

╔══════════════════════╤═══════════╤═══════════╗
║ @ember/*             │ Min       │ Gzip      ║
╟──────────────────────┼───────────┼───────────╢
║ Total                │ 313.42 KB │ 181.95 KB ║
╟──────────────────────┼───────────┼───────────╢
║ -internals           │ 36.65 KB  │ 26.23 KB  ║
║ application          │ 13.23 KB  │ 8.09 KB   ║
║ array                │ 13.01 KB  │ 7.46 KB   ║
║ canary-features      │ 304 B     │ 389 B     ║
║ component            │ 2.05 KB   │ 1.64 KB   ║
║ controller           │ 1.96 KB   │ 1.41 KB   ║
║ debug                │ 11.69 KB  │ 8.12 KB   ║
║ deprecated-features  │ 31 B      │ 77 B      ║
║ destroyable          │ 561 B     │ 383 B     ║
║ enumerable           │ 259 B     │ 387 B     ║
║ helper               │ 1.08 KB   │ 803 B     ║
║ instrumentation      │ 2.43 KB   │ 1.79 KB   ║
║ modifier             │ 1.22 KB   │ 966 B     ║
║ object               │ 35.94 KB  │ 22.16 KB  ║
║ owner                │ 159 B     │ 178 B     ║
║ renderer             │ 630 B     │ 492 B     ║
║ routing              │ 59.33 KB  │ 34.13 KB  ║
║ runloop              │ 2.36 KB   │ 1.5 KB    ║
║ service              │ 1 KB      │ 845 B     ║
║ template             │ 654 B     │ 519 B     ║
║ template-compilation │ 429 B     │ 366 B     ║
║ template-compiler    │ 123.08 KB │ 59.45 KB  ║
║ template-factory     │ 370 B     │ 374 B     ║
║ test                 │ 923 B     │ 627 B     ║
║ utils                │ 4.11 KB   │ 3.6 KB    ║
║ version              │ 55 B      │ 131 B     ║
╚══════════════════════╧═══════════╧═══════════╝

╔═════════════════╤══════════╤══════════╗
║ @glimmer/*      │ Min      │ Gzip     ║
╟─────────────────┼──────────┼──────────╢
║ Total           │ 38.6 KB  │ 21.82 KB ║
╟─────────────────┼──────────┼──────────╢
║ destroyable     │ 2.77 KB  │ 1.39 KB  ║
║ encoder         │ 81 B     │ 171 B    ║
║ env             │ 38 B     │ 87 B     ║
║ global-context  │ 886 B    │ 545 B    ║
║ manager         │ 977 B    │ 608 B    ║
║ node            │ 175 B    │ 245 B    ║
║ opcode-compiler │ 1.11 KB  │ 894 B    ║
║ owner           │ 159 B    │ 202 B    ║
║ program         │ 252 B    │ 301 B    ║
║ reference       │ 548 B    │ 531 B    ║
║ runtime         │ 10.32 KB │ 5.22 KB  ║
║ tracking        │ 1.34 KB  │ 1.16 KB  ║
║ util            │ 1.94 KB  │ 1.68 KB  ║
║ validator       │ 15.75 KB │ 6.96 KB  ║
║ vm              │ 495 B    │ 569 B    ║
║ wire-format     │ 1.84 KB  │ 1.35 KB  ║
╚═════════════════╧══════════╧══════════╝

Update compile-options.ts Enhance documentation for private fields support Updated documentation to reflect support for private fields in templates. Enable access to private properties in Glimmer templates This fix enables access to private class properties in Glimmer templates, resolving issues with private fields being treated as undefined. It includes updates to the template compiler and documentation to support private field identifiers. Create test-private-fields.html Remove private fields test HTML file Update FIX_SUMMARY.md Delete FIX_SUMMARY.md Delete test-private-fields.html

Aniruddh-14 and others added 8 commits February 12, 2026 03:25

Fix private field access for the runtime compiler

81e2c7c

ope

5bac3ff

lint:fix

20bc382

explicit scope tests

89b09ee

Checkpoint

d36323d

Fix types

cb878ec

Refactor a smidge

871bac1

NullVoxPopuli force-pushed the nvp/private-field-access branch from dc9b295 to 871bac1 Compare February 13, 2026 03:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix private field access#21088

Fix private field access#21088
NullVoxPopuli wants to merge 8 commits intomainfrom
nvp/private-field-access

NullVoxPopuli commented Feb 11, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Feb 11, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

NullVoxPopuli commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

NullVoxPopuli commented Feb 11, 2026 •

edited

Loading

github-actions bot commented Feb 11, 2026 •

edited

Loading