Fix packageMeta race condition: scan in-memory bundle instead of disk#21114
Merged
NullVoxPopuli merged 2 commits intonvp/split-buildfrom Feb 24, 2026
Merged
Fix packageMeta race condition: scan in-memory bundle instead of disk#21114NullVoxPopuli merged 2 commits intonvp/split-buildfrom
NullVoxPopuli merged 2 commits intonvp/split-buildfrom
Conversation
Co-authored-by: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Fix production build and package.json export condition
Fix packageMeta race condition: scan in-memory bundle instead of disk
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
packageMeta()'sgenerateBundlehook scanneddist/packagesfrom disk to buildember-addon.renamed-modules. SincegenerateBundlefires before rollup writes files to disk, anddist/dist-prodare gitignored, a fresh CI build always producedrenamed-modules: {}— causing@embroider/viteto have no module redirects and the benchmark app'svite buildto fail withhandleInvalidResolvedId.The main branch accidentally worked because
packageMetaran on two sequential configs; the second run'sgenerateBundlefired after the first config had already written its files to disk. The race condition fix (runningpackageMetaonly once on config 1) broke that accidental timing dependency.Fix
Scan the in-memory
bundleparameter ofgenerateBundleinstead of the filesystem:pruneEmptyBundlesalready runs beforepackageMetaand mutates the sharedbundleobject in-place, so pruned entries are correctly excluded.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.