Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 6 additions & 11 deletions text/1003-deprecation-import-ember-from-ember.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
stage: released
stage: recommended
start-date: 2024-01-22T00:00:00.000Z
release-date:
release-versions:
Expand All @@ -15,6 +15,7 @@ prs:
accepted: 'https://github.com/emberjs/rfcs/pull/1003'
ready-for-release: 'https://github.com/emberjs/rfcs/pull/1015'
released: 'https://github.com/emberjs/rfcs/pull/1084'
recommended: 'https://github.com/emberjs/rfcs/pull/1110'
project-link:
---

Expand Down Expand Up @@ -353,6 +354,7 @@ Unless otherwise stated, there will not be usage-based decision on these, as the
|🌐 | `Ember._on` | `import { on } from '@ember/modifier';` |
|🌐 | `Ember._fn` | `import { fn } from '@ember/helper';` |
|🌐 | `Ember.ENV` | `import MyEnv from '<my-app>/config/environment';` (for apps) or `owner.resolveRegistration('config:environment')` for addons|
|🌐 | `Ember.libraries` | `import { libraries } from '@ember/-internals/metal';` |


[RFC-615]: https://rfcs.emberjs.com/id/0615-autotracking-memoization
Expand All @@ -364,17 +366,10 @@ These can happen in any order
- Add deprecations to each `Ember.*` access
- Add the [Testing utilities](#testing-utilities) to `@ember/test`, if needed.
- Add an `@ember/version` package to `ember-source`
- Add re-exports of private APIs, `ComputedProperty`, and `_setClassicDecorator`
These will still be deprecated on `Ember.`, and will be deprecated themselves as we progress through deprecating Ember Classic.
- ~Add re-exports of private APIs, `ComputedProperty`, and `_setClassicDecorator`~
~These will still be deprecated on `Ember.`, and will be deprecated themselves as we progress through deprecating Ember Classic.~
This was proposed back when ember-concurrency relied on it, but current versions no longer do.
- Update ember-inspector to use imports for the internals and instrumentation APIs
- Add `@ember/inspector-support` to `ember-source` to manage things like `LIBRARIES`.
```js
import { libraries } from '@ember/inspector-support';

libraries.add('ember-data', '5.3.1');
// and/or
libraries.addAll(depInfoFromPlugin);
```
- Add deprecation guide entries for each API

## How We Teach This
Expand Down