-
-
Notifications
You must be signed in to change notification settings - Fork 410
v2 addon by default #985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
v2 addon by default #985
Changes from 3 commits
Commits
Show all changes
57 commits
Select commit
Hold shift + click to select a range
408629e
v2 addon by default
NullVoxPopuli 62cd65e
Update frontmatter
NullVoxPopuli 76d33e8
rename file
NullVoxPopuli 1940dd8
Apply suggestions from code review
achambers e37f662
Update making v2 addon blueprint default
NullVoxPopuli 662b52d
Add some details about @ember/addon-blueprint
NullVoxPopuli 7daadcf
updates
NullVoxPopuli 44904c2
updates
NullVoxPopuli 1cf00f5
mention influence of the v2 app blueprint
NullVoxPopuli 479c867
Be Thorough
NullVoxPopuli 938f49c
Updates
NullVoxPopuli 42ef012
Updates
NullVoxPopuli 6d2a115
More how we teach this
NullVoxPopuli 6e17a96
Updates
NullVoxPopuli 3defed6
Update text/0985-v2-addon-by-default.md
NullVoxPopuli 0dd342d
Sync with blueprint
NullVoxPopuli 508a003
Tighten verbiage
NullVoxPopuli 47fd82d
ope
NullVoxPopuli 63e9cf2
Update text/0985-v2-addon-by-default.md
NullVoxPopuli ec14163
Prose updates
NullVoxPopuli edc3a3c
Organize some less important details in <details>
NullVoxPopuli 01cd9d3
Add note at the bottom for previously undiscussed 'how to migrate'
NullVoxPopuli 1de27a1
Add some reference data
NullVoxPopuli 8e9dfdd
Sort by recent downloads
NullVoxPopuli 0472512
Remove stats (I should move them to a blog or something), also: add n…
NullVoxPopuli dbf36f8
Mention error about generato
NullVoxPopuli d0c0fd5
Add note about releasing
NullVoxPopuli 9554501
Update text/0985-v2-addon-by-default.md
NullVoxPopuli 971e0a7
Address review comments on RFC #985
NullVoxPopuli 3b65f07
Merge pull request #14 from NullVoxPopuli-ai-agent/address-pr-985-rev…
NullVoxPopuli 9484443
Add section on in-repo addons migration path
NullVoxPopuli 21815fd
Merge pull request #15 from NullVoxPopuli-ai-agent/address-in-repo-ad…
NullVoxPopuli 5034674
Add non-built addon flag to Detailed design
NullVoxPopuli 1147946
Merge pull request #16 from NullVoxPopuli-ai-agent/non-built-addon-flag
NullVoxPopuli 8fdc87b
Updates prompted by @void_malex
NullVoxPopuli 38cebc1
Remove 'release strategy' > off topic. Remove example > potential out…
NullVoxPopuli 0ce87dd
Add note about hbs
NullVoxPopuli 7e65afd
Add another alt
NullVoxPopuli cd2cc27
Move secondary information to the appendix
NullVoxPopuli 06a7c37
Don't mention CLI docs
NullVoxPopuli 2aa0971
Add note about exports and imports
NullVoxPopuli 0b1a550
add note about monorepo
NullVoxPopuli 48bc2d8
Remove extensions from unpublished blurb
NullVoxPopuli ba0d1d1
Update detailed design
NullVoxPopuli ef72292
Reduce
NullVoxPopuli e89ce78
Simplify note on sub-path imports
NullVoxPopuli c7147c9
Remove unresolved questions
NullVoxPopuli 168ec4d
Generators previously unresolved questions update
NullVoxPopuli 01f0319
Simplify
NullVoxPopuli 012ce85
Simplify
NullVoxPopuli 747f53b
copy from v2 app
NullVoxPopuli 2c75ef3
Simplify
NullVoxPopuli 7b10a46
Clarify
NullVoxPopuli 035baf1
More clarify
NullVoxPopuli b634468
Remove line
NullVoxPopuli 756054c
Add note about export conditions
NullVoxPopuli b2addc3
Merge branch 'main' into v2-addon-by-default
ef4 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| --- | ||
| stage: accepted | ||
| start-date: 2023-11-02T16:05:11.000Z | ||
| release-date: # In format YYYY-MM-DDT00:00:00.000Z | ||
| release-versions: | ||
| teams: # delete teams that aren't relevant | ||
| - cli | ||
| - data | ||
| - framework | ||
| - learning | ||
| - steering | ||
| - typescript | ||
| prs: | ||
| accepted: https://github.com/emberjs/rfcs/pull/985 | ||
| project-link: | ||
| suite: | ||
| --- | ||
|
|
||
| <!--- | ||
| Directions for above: | ||
|
|
||
| stage: Leave as is | ||
| start-date: Fill in with today's date, 2032-12-01T00:00:00.000Z | ||
| release-date: Leave as is | ||
| release-versions: Leave as is | ||
| teams: Include only the [team(s)](README.md#relevant-teams) for which this RFC applies | ||
| prs: | ||
| accepted: Fill this in with the URL for the Proposal RFC PR | ||
| project-link: Leave as is | ||
| suite: Leave as is | ||
| --> | ||
|
|
||
| # Change the default addon blueprint | ||
|
|
||
| ## Summary | ||
|
|
||
| `@embroider/addon-blueprint` has been in progress for a while, it's good stuff. | ||
|
|
||
|
|
||
| ## Motivation | ||
|
|
||
| We want to encourage folks use v2 addons instead of the classic addon blueprint. | ||
|
achambers marked this conversation as resolved.
Outdated
|
||
|
|
||
| V1 addons are built by apps on every boot, every build. | ||
| V2 addons are built at publish time, so the app can build faster. | ||
|
|
||
| ## Detailed design | ||
|
|
||
| `@embroider/addon-blueprint` will remain its own repo. `ember addon` will use this by default without a flag at some point. | ||
|
NullVoxPopuli marked this conversation as resolved.
Outdated
|
||
|
|
||
|
NullVoxPopuli marked this conversation as resolved.
|
||
| ## How we teach this | ||
|
NullVoxPopuli marked this conversation as resolved.
|
||
|
|
||
| > What names and terminology work best for these concepts and why? How is this | ||
|
NullVoxPopuli marked this conversation as resolved.
Outdated
|
||
| idea best presented? As a continuation of existing Ember patterns, or as a | ||
| wholly new one? | ||
|
|
||
| > Would the acceptance of this proposal mean the Ember guides must be | ||
| re-organized or altered? Does it change how Ember is taught to new users | ||
| at any level? | ||
|
|
||
| > How should this feature be introduced and taught to existing Ember | ||
| users? | ||
|
|
||
| ## Drawbacks | ||
|
|
||
| > Why should we *not* do this? Please consider the impact on teaching Ember, | ||
| on the integration of this feature with other existing and planned features, | ||
| on the impact of the API churn on existing apps, etc. | ||
|
|
||
| > There are tradeoffs to choosing any path, please attempt to identify them here. | ||
|
|
||
| ## Alternatives | ||
|
|
||
| > What other designs have been considered? What is the impact of not doing this? | ||
|
|
||
| > This section could also include prior art, that is, how other frameworks in the same domain have solved this problem. | ||
|
|
||
| ## Unresolved questions | ||
|
|
||
| > Optional, but suggested for first drafts. What parts of the design are still | ||
| TBD? | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.