feat(web-vitals): collect all vitals metrics by default#1166
Open
joseph-embrace wants to merge 1 commit intomainfrom
Open
feat(web-vitals): collect all vitals metrics by default#1166joseph-embrace wants to merge 1 commit intomainfrom
joseph-embrace wants to merge 1 commit intomainfrom
Conversation
Contributor
Chrome DevTools Protocol Tracing (Script: 107.45ms, Heap: 14.34MB)
Lighthouse (Script Eval: 123.94ms)
|
jpmunz
reviewed
Feb 27, 2026
| public constructor({ | ||
| diag, | ||
| perf, | ||
| trackingLevel = 'core', |
Contributor
There was a problem hiding this comment.
looks like we briefly use this as an example in the README that we should probably switch to something else:
embrace-web-sdk/packages/web-sdk/README.md
Line 259 in 70c310a
overbalance
reviewed
Feb 27, 2026
Contributor
I think this would be fine for a minor release, it's similar to adding in a new instrumentation that will start collecting more data by default. The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem is this solving?
We want to start collecting all web vitals metrics by default. Right now we're only collecting the core web vitals.
Short description of changes
How has this been tested?
Checklist