Skip to content

chore: add eslint to check()#1168

Merged
overbalance merged 1 commit intomainfrom
overbalance/add-eslint-to-local-check
Feb 27, 2026
Merged

chore: add eslint to check()#1168
overbalance merged 1 commit intomainfrom
overbalance/add-eslint-to-local-check

Conversation

@overbalance
Copy link
Contributor

What problem is this solving?

The local check script only ran tsc, so eslint issues weren't caught until CI.

Short description of changes

  • Add eslint to the check script so it runs alongside tsc locally
  • Remove redundant dist/ path from check:dist (config already specifies targets)

Testing

  • npm run check from packages/web-sdk/

@github-actions
Copy link
Contributor

github-actions bot commented Feb 27, 2026

Chrome DevTools Protocol Tracing (Script: 113.38ms, Heap: 14.35MB)
Number of Requests Size of Requests Script Duration Task Duration Heap Used Size
Requests +3 requests +30.00 KB
Page Loaded +16.71 ms +3.59 ms +1.02 MB
Generate 100 fetch requests +23.55 ms +105.50 ms +1.66 MB
Generate 100 XHR requests +42.37 ms +128.71 ms +1.98 MB
Click 100 buttons and generate 100 logs +20.76 ms +24.15 ms +3.28 MB
Throw a 100 exceptions +2.41 ms +21.88 ms +2.91 MB
End Session +7.58 ms +19.09 ms +3.50 MB
Total +3 requests +30.00 KB +113.38 ms +302.92 ms +14.35 MB
Lighthouse (Script Eval: 54.97ms)
Difference Description
Total Blocking Time 0 ms Difference in Total Blocking Time: Sum of all time periods between FCP and Time to Interactive, when task length exceeded 50ms, expressed in milliseconds. Learn more about the Total Blocking Time metric.
Main Thread Time +76.24 ms Difference in Main Thread Time: Consider reducing the time spent parsing, compiling and executing JS. You may find delivering smaller JS payloads helps with this. Learn how to minimize main-thread work
Script Evaluation Time +54.97 ms Difference in Script Evaluation Time: Consider reducing the time spent parsing, compiling, and executing JS. You may find delivering smaller JS payloads helps with this. Learn how to reduce Javascript execution time.
Platform Tests (vite-7 es2015 gzip: 66.28KB)

vite-6 Platform Tests

Total Uncompressed Size Total Gzip Size
vite-6 - es2015 +186.31 KB +66.33 KB

vite-7 Platform Tests

Total Uncompressed Size Total Gzip Size
vite-7 - es2015 +186.31 KB +66.28 KB

webpack-5 Platform Tests

Total Uncompressed Size Total Gzip Size
webpack-5 - es2015 +136.17 KB +49.26 KB

@overbalance overbalance merged commit 84ac459 into main Feb 27, 2026
18 checks passed
@overbalance overbalance deleted the overbalance/add-eslint-to-local-check branch February 27, 2026 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants