Closed
Conversation
NullVoxPopuli
commented
Aug 17, 2023
| @@ -9,8 +9,12 @@ | |||
| "license": "MIT", | |||
| "author": "simonihmig <simon.ihmig@kaliber5.de>", | |||
| "scripts": { | |||
Collaborator
Author
There was a problem hiding this comment.
We have not previously been running prettier on this repo, so we have more changes than normal
|
Could we also change the config so it only uses single quotes for js/ts code and doubles for everything else? We did a similar change in the v1 and app blueprint a while ago: https://github.com/ember-cli/ember-cli/pull/10062/files I was planning to PR it but it seems that will most likely conflict with this one 😄. This is what I did to support gjs in a v1 addon, but for v2 we probably need to add .cjs and .mjs as well?: |
Collaborator
Author
|
Implemented in #320 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review per commit.
We have not been running prettier on this repo, so the changes are bigger than normal.
We also get additional errors with prettier in the addon, (seen in #138)
Context:
Benefits:
turboornx