Remove ember-source as a peerDependency#339
Merged
NullVoxPopuli merged 3 commits intomainfrom May 10, 2025
Merged
Conversation
NullVoxPopuli
force-pushed
the
NullVoxPopuli-patch-4
branch
from
20a57c0 to
0a41842
Compare
Merged
This was referenced May 10, 2025
NullVoxPopuli
added a commit
to emberjs/ember-qunit
that referenced
this pull request
May 13, 2025
is extraneous, and the embroider/auto-import infra know where to get ember-source from. It's not _wrong_ to include, but it requires folks' manage their deps correctly -- so we can be a little more forgiving to maintainers by just omitting this. From PR descriptions elsewhere: - ember-source: removed because the embroider / auto-import know what we intend - it's not bad to have if someone manages their dep graph correctly, which is easier with pnpm, but not everyone gets it right, and folks have a hard time tracking down errors - @glimmer/tracking removed because it's a real package, but one we don't want to use. This comes up in embroider/vite where the presence of real packages always takes precedence over virtual packages. This is actually problematic because it can break reactivity in subtle ways, even if a dep graph is correct - allowing duplicates of dependencies, which for the glimmer internals, we don't want. Related: - cibernox/ember-power-calendar#550 - lifeart/ember-click-outside-modifier#47 - tracked-tools/ember-async-data#854 - warp-drive-data/warp-drive#9986 - ember-animation/ember-animated#779 - emberjs/ember-element-helper#125 - CrowdStrike/ember-headless-form#574 - adopted-ember-addons/ember-sortable#620 - ember-cli/ember-app-blueprint#7 - ember-cli/ember-cli#10697 - ember-cli/ember-addon-blueprint#35 - embroider-build/addon-blueprint#339 - ember-polyfills/ember-functions-as-helper-polyfill#151 - jelhan/ember-style-modifier#312 - jmurphyau/ember-truth-helpers#211 - ember-modifier/ember-modifier#949 - tracked-tools/tracked-toolbox#211 - emberjs/ember-test-helpers#1543 - NullVoxPopuli/ember-resources#1189 - NullVoxPopuli/ember-modify-based-class-resource#20 - universal-ember/kolay#187 - universal-ember/reactiveweb#139 - universal-ember/ember-primitives#471 - universal-ember/docs-support#77
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the embroider/auto-import infra make it so we don't need to declare this -- and peer problems will be easier if no one declares it.
I feel like it used to be needed, but whatever situation that was may have been a bug (or a misunderstanding of how to make dependencySatisfies work)