fix(deps): update dependency starlette to v0.40.0 [security] #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
==0.13.8->==0.40.0==0.14.2->==0.40.0==0.36.3->==0.40.0>= 0.13, <0.15->>=0.40.0, <0.41MultipartParser denial of service with too many fields or files
CVE-2023-30798 / GHSA-74m5-2c7w-9w3x / PYSEC-2023-48
More information
Details
Impact
The
MultipartParserusing the packagepython-multipartaccepts an unlimited number of multipart parts (form fields or files).Processing too many parts results in high CPU usage and high memory usage, eventually leading to an OOM process kill.
This can be triggered by sending too many small form fields with no content, or too many empty files.
For this to take effect application code has to:
python-multipartinstalled andrequest.form()UploadFileparameters, which in turn callsrequest.form().Patches
The vulnerability is solved in Starlette 0.25.0 by making the maximum fields and files customizable and with a sensible default (1000).
Applications will be secure by just upgrading their Starlette version to 0.25.0 (or FastAPI to 0.92.0).
If application code needs to customize the new max field and file number, there are new
request.form()parameters (with the default values):max_files=1000max_fields=1000Workarounds
Applications that don't install
python-multipartor that don't use form fields are safe.In older versions, it's also possible to instead of calling
request.form()callrequest.stream()and parse the form data in internal code.In most cases, the best solution is to upgrade the Starlette version.
References
This was reported in private by @das7pad via internal email. He also coordinated the fix across multiple frameworks and parsers.
The details about how
multipart/form-datais structured and parsed are in the RFC 7578.Severity
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:HReferences
This data is provided by OSV and the GitHub Advisory Database (CC-BY 4.0).
CVE-2023-30798 / GHSA-74m5-2c7w-9w3x / PYSEC-2023-48
More information
Details
There MultipartParser usage in Encode's Starlette python framework before versions 0.25.0 allows an unauthenticated and remote attacker to specify any number of form fields or files which can cause excessive memory usage resulting in denial of service of the HTTP service.
Severity
Unknown
References
This data is provided by OSV and the PyPI Advisory Database (CC-BY 4.0).
Starlette has Path Traversal vulnerability in StaticFiles
CVE-2023-29159 / GHSA-v5gw-mw7f-84px / PYSEC-2023-83
More information
Details
Summary
When using
StaticFiles, if there's a file or directory that starts with the same name as theStaticFilesdirectory, that file or directory is also exposed viaStaticFileswhich is a path traversal vulnerability.Details
The root cause of this issue is the usage of
os.path.commonprefix():https://github.com/encode/starlette/blob/4bab981d9e870f6cee1bd4cd59b87ddaf355b2dc/starlette/staticfiles.py#L172-L174
As stated in the Python documentation (https://docs.python.org/3/library/os.path.html#os.path.commonprefix) this function returns the longest prefix common to paths.
When passing a path like
/static/../static1.txt,os.path.commonprefix([full_path, directory])returns./staticwhich is the common part of./static1.txtand./static, It refers to/static/../static1.txtbecause it is considered in the staticfiles directory. As a result, it becomes possible to view files that should not be open to the public.The solution is to use
os.path.commonpathas the Python documentation explains thatos.path.commonprefixworks a character at a time, it does not treat the arguments as paths.PoC
In order to reproduce the issue, you need to create the following structure:
And run the
Starletteapp with:And running the commands:
The
static1.txtand the directorystatic_disalloware exposed.Impact
Confidentiality is breached: An attacker may obtain files that should not be open to the public.
Credits
Security researcher Masashi Yamane of LAC Co., Ltd reported this vulnerability to JPCERT/CC Vulnerability Coordination Group and they contacted us to coordinate a patch for the security issue.
Severity
CVSS:3.1/AV:N/AC:H/PR:N/UI:N/S:U/C:L/I:N/A:NReferences
This data is provided by OSV and the GitHub Advisory Database (CC-BY 4.0).
CVE-2023-29159 / GHSA-v5gw-mw7f-84px / PYSEC-2023-83
More information
Details
Directory traversal vulnerability in Starlette versions 0.13.5 and later and prior to 0.27.0 allows a remote unauthenticated attacker to view files in a web service which was built using Starlette.
Severity
Unknown
References
This data is provided by OSV and the PyPI Advisory Database (CC-BY 4.0).
Starlette Denial of service (DoS) via multipart/form-data
CVE-2024-47874 / GHSA-f96h-pmfr-66vw
More information
Details
Summary
Starlette treats
multipart/form-dataparts without afilenameas text form fields and buffers those in byte strings with no size limit. This allows an attacker to upload arbitrary large form fields and cause Starlette to both slow down significantly due to excessive memory allocations and copy operations, and also consume more and more memory until the server starts swapping and grinds to a halt, or the OS terminates the server process with an OOM error. Uploading multiple such requests in parallel may be enough to render a service practically unusable, even if reasonable request size limits are enforced by a reverse proxy in front of Starlette.PoC
curl http://localhost:8000 -F 'big=</dev/urandom'Impact
This Denial of service (DoS) vulnerability affects all applications built with Starlette (or FastAPI) accepting form requests.
Severity
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:NReferences
This data is provided by OSV and the GitHub Advisory Database (CC-BY 4.0).
Release Notes
encode/starlette (starlette)
v0.40.0: Version 0.40.0Compare Source
This release fixes a Denial of service (DoS) via
multipart/form-datarequests.You can view the full security advisory:
GHSA-f96h-pmfr-66vw
Fixed
max_part_sizetoMultiPartParserto limit the size of parts inmultipart/form-datarequests fd038f3.
v0.39.2: Version 0.39.2Compare Source
Fixed
request.url_forwhen only "app" scope is available #2672.python-multipart==0.0.12#2708.Full Changelog: Kludex/starlette@0.39.1...0.39.2
v0.39.1: Version 0.39.1Compare Source
Fixed
responses.pyandschemas.py#2700.get_route_pathby removing regular expression usage #2701.FileResponse.chunk_sizewhen handling multiple ranges #2703.token_hexfor generating multipart boundary strings #2702.Full Changelog: Kludex/starlette@0.39.0...0.39.1
v0.39.0: Version 0.39.0Compare Source
Added
FileResponse#2697Full Changelog: Kludex/starlette@0.38.6...0.39.0
v0.38.6: Version 0.38.6Compare Source
Fixed
MemoryObjectReceiveStreaminTestClient#2693.Full Changelog: Kludex/starlette@0.38.5...0.38.6
v0.38.5: Version 0.38.5Compare Source
Fixed
BackgroundTasksfrom withinBaseHTTPMiddleware#2688.This behavior was removed in 0.38.3, and is now restored.
Full Changelog: Kludex/starlette@0.38.4...0.38.5
v0.38.4: Version 0.38.4Compare Source
Fixed
root_pathremoval inget_route_pathfunction #2600Full Changelog: Kludex/starlette@0.38.3...0.38.4
v0.38.3: Version 0.38.3Compare Source
Added
Fixed
BaseHTTPMiddlewareviaStreamingResponse#2620.Full Changelog: Kludex/starlette@0.38.2...0.38.3
v0.38.2: Version 0.38.2Compare Source
Fixed
routing.get_name()not to assume all routines have__name__#2648Full Changelog: Kludex/starlette@0.38.1...0.38.2
v0.38.1: Version 0.38.1Compare Source
Removed
Full Changelog: Kludex/starlette@0.38.0...0.38.1
v0.38.0: Version 0.38.0Compare Source
Added
memoryviewinStreamingResponseandResponse#2576and #2577.
StaticFiles#2583.Changed
Jinja2Templateinstantiation parameters #2568.Fixed
WebSocketTestSession#2597.Full Changelog: Kludex/starlette@0.37.2...0.38.0
v0.37.2: Version 0.37.2Compare Source
Added
bytesto_RequestDatatype #2510.Fixed
scope["client"]toNoneonTestClient(#2377)" #2525.appargument passed tohttpx.Clienton theTestClient#2526.Full Changelog: Kludex/starlette@0.37.1...0.37.2
v0.37.1: Version 0.37.1Compare Source
Fixed
Config#2485.Full Changelog: Kludex/starlette@0.37.0...0.37.1
v0.37.0: Version 0.37.0Compare Source
Added
Full Changelog: Kludex/starlette@0.36.3...0.37.0
v0.36.3: Version 0.36.3Compare Source
Fixed
anyio.Eventon async context #2459.Full Changelog: Kludex/starlette@0.36.2...0.36.3
v0.36.2: Version 0.36.2Compare Source
Fixed
python-multipartto0.0.713e5c26.Content-Type#2443.Full Changelog: Kludex/starlette@0.36.1...0.36.2
v0.36.1: Version 0.36.1Compare Source
Fixed
Full Changelog: Kludex/starlette@0.36.0...0.36.1
v0.36.0: Version 0.36.0Compare Source
Added
pathsendextension #2435.WebSocketTestSessionon close #2427.WebSocketDisconnectwhenWebSocket.send()exceptsIOError#2425.FileNotFoundErrorwhen theenv_fileparameter onConfigis not valid #2422.Full Changelog: Kludex/starlette@0.35.1...0.36.0
v0.35.1: Version 0.35.1Compare Source
Fixed
FileResponseinside ofStaticFiles#2406.typing-extensionsoptional again #2409.Full Changelog: Kludex/starlette@0.35.0...0.35.1
v0.35.0: Version 0.35.0Compare Source
Added
*argstoMiddlewareand improve its type hints #2381.Fixed
IterableinsteadIteratoroniterate_in_threadpool#2362.Changes
root_pathto keep compatibility with mounted ASGI applications and WSGI #2400.scope["client"]toNoneonTestClient#2377.Full Changelog: Kludex/starlette@0.34.0...0.35.0
v0.34.0: Version 0.34.0Compare Source
Added
ParamSpecforrun_in_threadpool#2375.UploadFile.__repr__#2360.Fixed
TestClient#2376.StaticFiles#2334.Deprecated
FileResponse(method=...)parameter #2366.Full Changelog: Kludex/starlette@0.33.0...0.34.0
v0.33.0: Version 0.33.0Compare Source
Added
middlewareperRoute/WebSocketRoute#2349.middlewareperRouter#2351.Fixed
"path"and"root_path"scope keys #2352.ensure_ascii=Falseonjson.dumps()forWebSocket.send_json()#2341.v0.32.0.post1: Version 0.32.0.post1Compare Source
Fixed
v0.32.0: Version 0.32.0Compare Source
Added
reasononWebSocketDisconnect#2309.domainparameter toSessionMiddleware#2280.Changed
HTMLResponseinstead ofResponseon_TemplateResponse#2274.Response.rendertype annotation to its pre-0.31.0 state #2264.Full Changelog: Kludex/starlette@0.31.1...0.32.0
v0.31.1: Version 0.31.1Compare Source
Fixed
exceptiongroupisn't available #2231.url_forglobal for custom Jinja environments #2230.Full Changelog: Kludex/starlette@0.31.0...0.31.1
v0.31.0: Version 0.31.0Compare Source
Added
Fixed
TestClient#2219.Full Changelog: Kludex/starlette@0.30.0...0.31.0
v0.30.0: Version 0.30.0Compare Source
Removed
v0.29.0: Version 0.29.0Compare Source
Added
follow_redirectsparameter toTestClient#2207.__str__toHTTPExceptionandWebSocketException#2181.lifespantogether withon_startup/on_shutdown#2193.Hostto generate the OpenAPI schema #2183.requestargument toTemplateResponse#2191.Fixed
body_streamin casemore_body=FalseonBaseHTTPMiddleware#2194.Full Changelog: Kludex/starlette@0.28.0...0.29.0
v0.28.0: Version 0.28.0Compare Source
Changed
Request's body buffer for call_next inBaseHTTPMiddleware#1692.Route#2026.Added
envparameter toJinja2Templates, and deprecate**env_options#2159.httpxis not installed #2177.Fixed
templates url_for()#2127.Full Changelog: Kludex/starlette@0.27.0...0.28.0
v0.27.0: Version 0.27.0Compare Source
This release fixes a path traversal vulnerability in
StaticFiles. You can view the full security advisory:GHSA-v5gw-mw7f-84px
Added
send_jsonhttps://github.com/encode/starlette/pull/2128Fixed
commonprefixbycommonpathonStaticFiles1797de4.Full Changelog: Kludex/starlette@0.26.1...0.27.0
v0.26.1: Version 0.26.1Compare Source
Fixed
v0.26.0.post1: Version 0.26.0.post1Compare Source
Fixed
v0.26.0: Version 0.26.0Compare Source
Added
Changed
url_forsignature to return aURLinstance #1385.Fixed
url_for()andurl_path_for()#2050.Deprecated
on_startupandon_shutdownevents #2070.Full Changelog: Kludex/starlette@0.25.0...0.26.0
v0.25.0: Version 0.25.0Compare Source
Fixed
multipart/form-dataon theMultipartParser8c74c2c and #2036.v0.24.0: Version 0.24.0Compare Source
Added
StaticFilesto follow symlinks #1683.Request.form()as a context manager #1903.sizeattribute toUploadFile#1405.env_prefixargument toConfig#1990.stranddatetimeonexpiresparameter on theResponse.set_cookiemethod #1908.Changed
fileargument required onUploadFile#1413.Fixed
URL.replace#1965.v0.23.1: Version 0.23.1Compare Source
Fixed
body_streamif body is empty on theBaseHTTPMiddleware#1940.v0.23.0: Version 0.23.0Compare Source
Added
headersparameter to theTestClient#1966.Deprecated
StarletteandRouterdecorators #1897.Fixed
FloatConvertorregex #1973.v0.22.0: Version 0.22.0Compare Source
Changed
GZipMiddlewarewhen response includesContent-Encoding#1901.Fixed
unquote()from query parameters on theTestClient#1953.MutableHeaders._listis actually alist#1917.AnyIO#1936.v0.21.0: Version 0.21.0Compare Source
This release replaces the underlying HTTP client used on the
TestClient(requests➡️httpx), and as those clients differ a bit on their API, your test suite will likely break. To make the migration smoother, you can use thebump-testclienttool.Changed
requestswithhttpxinTestClient#1376.Added
WebSocketExceptionand support for WebSocket exception handlers #1263.middlewareparameter toMountclass #1649.__repr__for route classes #1864.Fixed
BackgroundTaskswere cancelled when usingBaseHTTPMiddlewareand client disconnected #1715.v0.20.4: Version 0.20.4Compare Source
Fixed
v0.20.3: Version 0.20.3Compare Source
Fixed
StaticFilesto follow symlinks" #1681.v0.20.2: Version 0.20.2Compare Source
Fixed
StaticFilesto follow symlinks #1337.v0.20.1: Version 0.20.1Compare Source
Fixed
boundaryis missing #1617.Content-Dispositionheader #1643.StreamingResponseonBaseHTTPMiddleware#1609.__bool__dunder forSecret#1625.v0.20.0: Version 0.20.0Compare Source
Removed
v0.19.1: Version 0.19.1Compare Source
Fixed
Route.namewhen created from methods #1553.TypeErroronwebsocket.disconnectwhen code isNone#1574.Deprecated
WS_1004_NO_STATUS_RCVDandWS_1005_ABNORMAL_CLOSUREin favor ofWS_1005_NO_STATUS_RCVDandWS_1006_ABNORMAL_CLOSURE, as the previous constants didn't match the WebSockets specs #1580.v0.19.0: Version 0.19.0Compare Source
Added
headersparameter toHTTPException#1435.405status code insert anAllowheader, as described by RFC 7231 #1436.contentargument inJSONResponseis now required #1431.FileResponse#1266.raw_pathtoTestClientscope #1445.MutableHeaders#1240.anyiorequired version range to>=3.4.0,<5.0#1421 and #1460.typing-extensions>=3.10requirement - used only on lower versions than Python 3.10 #1475.Fixed
BaseHTTPMiddlewarefrom hiding errors ofStreamingResponseand mounted applications #1459.SessionMiddlewareuses an explicitpath=..., instead of defaulting to the ASGI 'root_path' #1512.Request.clientis now compliant with the ASGI specifications #1462.KeyErrorat early stage for missing boundary #1349.Deprecated
run_until_first_complete#1443.v0.18.0: Version 0.18.0Compare Source
Added
FileResponse#1345.functools.partialinWebSocketRoute#1356.StaticFilespackages with directory #1350.Jinja2Templates#1401.HttpEndpoint#1346.websocket.acceptmessage #1361 and #1422.reasontoWebSocketclose ASGI event #1417.UploadFile#1382.Content-Lengthheader forContent-Length: 0cases #1395.SessionMiddleware.max_agenow acceptsNone, so cookie can last as long as the browser session #1387.Fixed
hashlib.md5()function onFileResponses ETag generation. The parameterusedforsecurityflag is set toFalse, if the flag is available on the system. This fixes an error raised on systems with FIPS enabled #1366 and #1410.path_paramstype onurl_path_for()method i.e. turnstrintoAny#1341.Hostnow ignoresporton routing #1322.v0.17.1: Version 0.17.1Compare Source
Fixed
IndexErrorin authenticationrequireswhen wrapped function arguments are distributed between*argsand**kwargs#1335.v0.17.0: Version 0.17.0Compare Source
Added
Response.delete_cookienow accepts the same parameters asResponse.set_cookie#1228.Jinja2Templatesconstructor to allowPathLike#1292.Fixed
HTTPConnection.__getitem__return type fromstrtotyping.Any#1118.ImmutableMultiDict.getlistreturn type fromtyping.List[str]totyping.List[typing.Any]#1235.OSErrorexceptions onStaticFiles#1220.StaticFiles404.html in HTML mode #1314.Removed
v0.16.0: Version 0.16.0Compare Source
Added
#1219
Fixed
starlette.websockets.WebSocketinstances are now hashable and compare by identity#1039
#1213,
#1227
Deprecated/removed
starlette.templates.Jinja2Templates.get_envwas removed#1218
starlette.testclient.TestClient.async_backendwas removed,the backend is now configured using constructor kwargs
#1211
starlette.router.Router(lifespan_context=)is deprecated. You should wrap your lifespan in@contextlib.asynccontextmanager.#1227
#1110
v0.15.0: Version 0.15.0Compare Source
0.15.0
This release includes major changes to the low-level asynchronous parts of Starlette. As a result, Starlette now depends on AnyIO and some minor API changes have occurred. Another significant change with this release is the deprecation of built-in GraphQL support.
Added
TestClient.websocket_connect()now must be used as a context manager.GZipMiddlewareis now adjustable - #1128.Fixed
CORSMiddleware. See #1111, #1112, #1113, #1199.RedirectResponsenow usesquoteinstead ofquote_plusencoding for theLocationheader to better match the behaviour in other frameworks such as Django - #1164.BaseHTTPMiddlewarewhen handling large responses - #1012 fixed via #1157Deprecated/removed
GraphQLAppclass has been deprecated and will be removed in a future release. Please see #619. GraphQL is not supported on Python 3.10.executorparameter toGraphQLAppwas removed. Useexecutor_classinstead.workersparameter toWSGIMiddlewarewas removed. This hasn't had any effect since Starlette v0.6.3.v0.14.2: Version 0.14.2Compare Source
Fixed
ServerErrorMiddlewarecompatibility with Python 3.9.1/3.8.7 when debug mode is enabled - #1132.ResourceWarnings when using theTestClientwith WebSocket endpoints - #1132.asyncendpoints wrapped infunctools.partialon Python 3.8+ - #1106.v0.14.1: Version 0.14.1Compare Source
Removed
UJSONResponsewas removed (this change was intended to be included in 0.14.0). Please see the documentation for how to implement responses using custom JSON serialization - #1074.v0.14.0: Version 0.14.0Compare Source
Added
StreamingResponse, allow custom async iterator such as objects from classes implementing__aiter__.functools.partialasync handlers in Python versions 3.6 and 3.7.Changed
asyncio.wait.format_exceptioninstead offormat_tbinServerErrorMiddleware'sdebugresponses.requiresdecorator.Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.