fix(deps): update dependency starlette to v0.40.0 [security] #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
==0.13.8
->==0.40.0
==0.14.2
->==0.40.0
==0.36.3
->==0.40.0
>= 0.13, <0.15
->>=0.40.0, <0.41
MultipartParser denial of service with too many fields or files
CVE-2023-30798 / GHSA-74m5-2c7w-9w3x / PYSEC-2023-48
More information
Details
Impact
The
MultipartParser
using the packagepython-multipart
accepts an unlimited number of multipart parts (form fields or files).Processing too many parts results in high CPU usage and high memory usage, eventually leading to an OOM process kill.
This can be triggered by sending too many small form fields with no content, or too many empty files.
For this to take effect application code has to:
python-multipart
installed andrequest.form()
UploadFile
parameters, which in turn callsrequest.form()
.Patches
The vulnerability is solved in Starlette 0.25.0 by making the maximum fields and files customizable and with a sensible default (1000).
Applications will be secure by just upgrading their Starlette version to 0.25.0 (or FastAPI to 0.92.0).
If application code needs to customize the new max field and file number, there are new
request.form()
parameters (with the default values):max_files=1000
max_fields=1000
Workarounds
Applications that don't install
python-multipart
or that don't use form fields are safe.In older versions, it's also possible to instead of calling
request.form()
callrequest.stream()
and parse the form data in internal code.In most cases, the best solution is to upgrade the Starlette version.
References
This was reported in private by @das7pad via internal email. He also coordinated the fix across multiple frameworks and parsers.
The details about how
multipart/form-data
is structured and parsed are in the RFC 7578.Severity
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H
References
This data is provided by OSV and the GitHub Advisory Database (CC-BY 4.0).
CVE-2023-30798 / GHSA-74m5-2c7w-9w3x / PYSEC-2023-48
More information
Details
There MultipartParser usage in Encode's Starlette python framework before versions 0.25.0 allows an unauthenticated and remote attacker to specify any number of form fields or files which can cause excessive memory usage resulting in denial of service of the HTTP service.
Severity
Unknown
References
This data is provided by OSV and the PyPI Advisory Database (CC-BY 4.0).
Starlette has Path Traversal vulnerability in StaticFiles
CVE-2023-29159 / GHSA-v5gw-mw7f-84px / PYSEC-2023-83
More information
Details
Summary
When using
StaticFiles
, if there's a file or directory that starts with the same name as theStaticFiles
directory, that file or directory is also exposed viaStaticFiles
which is a path traversal vulnerability.Details
The root cause of this issue is the usage of
os.path.commonprefix()
:https://github.com/encode/starlette/blob/4bab981d9e870f6cee1bd4cd59b87ddaf355b2dc/starlette/staticfiles.py#L172-L174
As stated in the Python documentation (https://docs.python.org/3/library/os.path.html#os.path.commonprefix) this function returns the longest prefix common to paths.
When passing a path like
/static/../static1.txt
,os.path.commonprefix([full_path, directory])
returns./static
which is the common part of./static1.txt
and./static
, It refers to/static/../static1.txt
because it is considered in the staticfiles directory. As a result, it becomes possible to view files that should not be open to the public.The solution is to use
os.path.commonpath
as the Python documentation explains thatos.path.commonprefix
works a character at a time, it does not treat the arguments as paths.PoC
In order to reproduce the issue, you need to create the following structure:
And run the
Starlette
app with:And running the commands:
The
static1.txt
and the directorystatic_disallow
are exposed.Impact
Confidentiality is breached: An attacker may obtain files that should not be open to the public.
Credits
Security researcher Masashi Yamane of LAC Co., Ltd reported this vulnerability to JPCERT/CC Vulnerability Coordination Group and they contacted us to coordinate a patch for the security issue.
Severity
CVSS:3.1/AV:N/AC:H/PR:N/UI:N/S:U/C:L/I:N/A:N
References
This data is provided by OSV and the GitHub Advisory Database (CC-BY 4.0).
CVE-2023-29159 / GHSA-v5gw-mw7f-84px / PYSEC-2023-83
More information
Details
Directory traversal vulnerability in Starlette versions 0.13.5 and later and prior to 0.27.0 allows a remote unauthenticated attacker to view files in a web service which was built using Starlette.
Severity
Unknown
References
This data is provided by OSV and the PyPI Advisory Database (CC-BY 4.0).
Starlette Denial of service (DoS) via multipart/form-data
CVE-2024-47874 / GHSA-f96h-pmfr-66vw
More information
Details
Summary
Starlette treats
multipart/form-data
parts without afilename
as text form fields and buffers those in byte strings with no size limit. This allows an attacker to upload arbitrary large form fields and cause Starlette to both slow down significantly due to excessive memory allocations and copy operations, and also consume more and more memory until the server starts swapping and grinds to a halt, or the OS terminates the server process with an OOM error. Uploading multiple such requests in parallel may be enough to render a service practically unusable, even if reasonable request size limits are enforced by a reverse proxy in front of Starlette.PoC
curl http://localhost:8000 -F 'big=</dev/urandom'
Impact
This Denial of service (DoS) vulnerability affects all applications built with Starlette (or FastAPI) accepting form requests.
Severity
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:N
References
This data is provided by OSV and the GitHub Advisory Database (CC-BY 4.0).
Release Notes
encode/starlette (starlette)
v0.40.0
: Version 0.40.0Compare Source
This release fixes a Denial of service (DoS) via
multipart/form-data
requests.You can view the full security advisory:
GHSA-f96h-pmfr-66vw
Fixed
max_part_size
toMultiPartParser
to limit the size of parts inmultipart/form-data
requests fd038f3.
v0.39.2
: Version 0.39.2Compare Source
Fixed
request.url_for
when only "app" scope is available #2672.python-multipart==0.0.12
#2708.Full Changelog: Kludex/starlette@0.39.1...0.39.2
v0.39.1
: Version 0.39.1Compare Source
Fixed
responses.py
andschemas.py
#2700.get_route_path
by removing regular expression usage #2701.FileResponse.chunk_size
when handling multiple ranges #2703.token_hex
for generating multipart boundary strings #2702.Full Changelog: Kludex/starlette@0.39.0...0.39.1
v0.39.0
: Version 0.39.0Compare Source
Added
FileResponse
#2697Full Changelog: Kludex/starlette@0.38.6...0.39.0
v0.38.6
: Version 0.38.6Compare Source
Fixed
MemoryObjectReceiveStream
inTestClient
#2693.Full Changelog: Kludex/starlette@0.38.5...0.38.6
v0.38.5
: Version 0.38.5Compare Source
Fixed
BackgroundTasks
from withinBaseHTTPMiddleware
#2688.This behavior was removed in 0.38.3, and is now restored.
Full Changelog: Kludex/starlette@0.38.4...0.38.5
v0.38.4
: Version 0.38.4Compare Source
Fixed
root_path
removal inget_route_path
function #2600Full Changelog: Kludex/starlette@0.38.3...0.38.4
v0.38.3
: Version 0.38.3Compare Source
Added
Fixed
BaseHTTPMiddleware
viaStreamingResponse
#2620.Full Changelog: Kludex/starlette@0.38.2...0.38.3
v0.38.2
: Version 0.38.2Compare Source
Fixed
routing.get_name()
not to assume all routines have__name__
#2648Full Changelog: Kludex/starlette@0.38.1...0.38.2
v0.38.1
: Version 0.38.1Compare Source
Removed
Full Changelog: Kludex/starlette@0.38.0...0.38.1
v0.38.0
: Version 0.38.0Compare Source
Added
memoryview
inStreamingResponse
andResponse
#2576and #2577.
StaticFiles
#2583.Changed
Jinja2Template
instantiation parameters #2568.Fixed
WebSocketTestSession
#2597.Full Changelog: Kludex/starlette@0.37.2...0.38.0
v0.37.2
: Version 0.37.2Compare Source
Added
bytes
to_RequestData
type #2510.Fixed
scope["client"]
toNone
onTestClient
(#2377)" #2525.app
argument passed tohttpx.Client
on theTestClient
#2526.Full Changelog: Kludex/starlette@0.37.1...0.37.2
v0.37.1
: Version 0.37.1Compare Source
Fixed
Config
#2485.Full Changelog: Kludex/starlette@0.37.0...0.37.1
v0.37.0
: Version 0.37.0Compare Source
Added
Full Changelog: Kludex/starlette@0.36.3...0.37.0
v0.36.3
: Version 0.36.3Compare Source
Fixed
anyio.Event
on async context #2459.Full Changelog: Kludex/starlette@0.36.2...0.36.3
v0.36.2
: Version 0.36.2Compare Source
Fixed
python-multipart
to0.0.7
13e5c26.Content-Type
#2443.Full Changelog: Kludex/starlette@0.36.1...0.36.2
v0.36.1
: Version 0.36.1Compare Source
Fixed
Full Changelog: Kludex/starlette@0.36.0...0.36.1
v0.36.0
: Version 0.36.0Compare Source
Added
pathsend
extension #2435.WebSocketTestSession
on close #2427.WebSocketDisconnect
whenWebSocket.send()
exceptsIOError
#2425.FileNotFoundError
when theenv_file
parameter onConfig
is not valid #2422.Full Changelog: Kludex/starlette@0.35.1...0.36.0
v0.35.1
: Version 0.35.1Compare Source
Fixed
FileResponse
inside ofStaticFiles
#2406.typing-extensions
optional again #2409.Full Changelog: Kludex/starlette@0.35.0...0.35.1
v0.35.0
: Version 0.35.0Compare Source
Added
*args
toMiddleware
and improve its type hints #2381.Fixed
Iterable
insteadIterator
oniterate_in_threadpool
#2362.Changes
root_path
to keep compatibility with mounted ASGI applications and WSGI #2400.scope["client"]
toNone
onTestClient
#2377.Full Changelog: Kludex/starlette@0.34.0...0.35.0
v0.34.0
: Version 0.34.0Compare Source
Added
ParamSpec
forrun_in_threadpool
#2375.UploadFile.__repr__
#2360.Fixed
TestClient
#2376.StaticFiles
#2334.Deprecated
FileResponse(method=...)
parameter #2366.Full Changelog: Kludex/starlette@0.33.0...0.34.0
v0.33.0
: Version 0.33.0Compare Source
Added
middleware
perRoute
/WebSocketRoute
#2349.middleware
perRouter
#2351.Fixed
"path"
and"root_path"
scope keys #2352.ensure_ascii=False
onjson.dumps()
forWebSocket.send_json()
#2341.v0.32.0.post1
: Version 0.32.0.post1Compare Source
Fixed
v0.32.0
: Version 0.32.0Compare Source
Added
reason
onWebSocketDisconnect
#2309.domain
parameter toSessionMiddleware
#2280.Changed
HTMLResponse
instead ofResponse
on_TemplateResponse
#2274.Response.render
type annotation to its pre-0.31.0 state #2264.Full Changelog: Kludex/starlette@0.31.1...0.32.0
v0.31.1
: Version 0.31.1Compare Source
Fixed
exceptiongroup
isn't available #2231.url_for
global for custom Jinja environments #2230.Full Changelog: Kludex/starlette@0.31.0...0.31.1
v0.31.0
: Version 0.31.0Compare Source
Added
Fixed
TestClient
#2219.Full Changelog: Kludex/starlette@0.30.0...0.31.0
v0.30.0
: Version 0.30.0Compare Source
Removed
v0.29.0
: Version 0.29.0Compare Source
Added
follow_redirects
parameter toTestClient
#2207.__str__
toHTTPException
andWebSocketException
#2181.lifespan
together withon_startup
/on_shutdown
#2193.Host
to generate the OpenAPI schema #2183.request
argument toTemplateResponse
#2191.Fixed
body_stream
in casemore_body=False
onBaseHTTPMiddleware
#2194.Full Changelog: Kludex/starlette@0.28.0...0.29.0
v0.28.0
: Version 0.28.0Compare Source
Changed
Request
's body buffer for call_next inBaseHTTPMiddleware
#1692.Route
#2026.Added
env
parameter toJinja2Templates
, and deprecate**env_options
#2159.httpx
is not installed #2177.Fixed
templates url_for()
#2127.Full Changelog: Kludex/starlette@0.27.0...0.28.0
v0.27.0
: Version 0.27.0Compare Source
This release fixes a path traversal vulnerability in
StaticFiles
. You can view the full security advisory:GHSA-v5gw-mw7f-84px
Added
send_json
https://github.com/encode/starlette/pull/2128Fixed
commonprefix
bycommonpath
onStaticFiles
1797de4.Full Changelog: Kludex/starlette@0.26.1...0.27.0
v0.26.1
: Version 0.26.1Compare Source
Fixed
v0.26.0.post1
: Version 0.26.0.post1Compare Source
Fixed
v0.26.0
: Version 0.26.0Compare Source
Added
Changed
url_for
signature to return aURL
instance #1385.Fixed
url_for()
andurl_path_for()
#2050.Deprecated
on_startup
andon_shutdown
events #2070.Full Changelog: Kludex/starlette@0.25.0...0.26.0
v0.25.0
: Version 0.25.0Compare Source
Fixed
multipart/form-data
on theMultipartParser
8c74c2c and #2036.v0.24.0
: Version 0.24.0Compare Source
Added
StaticFiles
to follow symlinks #1683.Request.form()
as a context manager #1903.size
attribute toUploadFile
#1405.env_prefix
argument toConfig
#1990.str
anddatetime
onexpires
parameter on theResponse.set_cookie
method #1908.Changed
file
argument required onUploadFile
#1413.Fixed
URL.replace
#1965.v0.23.1
: Version 0.23.1Compare Source
Fixed
body_stream
if body is empty on theBaseHTTPMiddleware
#1940.v0.23.0
: Version 0.23.0Compare Source
Added
headers
parameter to theTestClient
#1966.Deprecated
Starlette
andRouter
decorators #1897.Fixed
FloatConvertor
regex #1973.v0.22.0
: Version 0.22.0Compare Source
Changed
GZipMiddleware
when response includesContent-Encoding
#1901.Fixed
unquote()
from query parameters on theTestClient
#1953.MutableHeaders._list
is actually alist
#1917.AnyIO
#1936.v0.21.0
: Version 0.21.0Compare Source
This release replaces the underlying HTTP client used on the
TestClient
(requests
➡️httpx
), and as those clients differ a bit on their API, your test suite will likely break. To make the migration smoother, you can use thebump-testclient
tool.Changed
requests
withhttpx
inTestClient
#1376.Added
WebSocketException
and support for WebSocket exception handlers #1263.middleware
parameter toMount
class #1649.__repr__
for route classes #1864.Fixed
BackgroundTasks
were cancelled when usingBaseHTTPMiddleware
and client disconnected #1715.v0.20.4
: Version 0.20.4Compare Source
Fixed
v0.20.3
: Version 0.20.3Compare Source
Fixed
StaticFiles
to follow symlinks" #1681.v0.20.2
: Version 0.20.2Compare Source
Fixed
StaticFiles
to follow symlinks #1337.v0.20.1
: Version 0.20.1Compare Source
Fixed
boundary
is missing #1617.Content-Disposition
header #1643.StreamingResponse
onBaseHTTPMiddleware
#1609.__bool__
dunder forSecret
#1625.v0.20.0
: Version 0.20.0Compare Source
Removed
v0.19.1
: Version 0.19.1Compare Source
Fixed
Route.name
when created from methods #1553.TypeError
onwebsocket.disconnect
when code isNone
#1574.Deprecated
WS_1004_NO_STATUS_RCVD
andWS_1005_ABNORMAL_CLOSURE
in favor ofWS_1005_NO_STATUS_RCVD
andWS_1006_ABNORMAL_CLOSURE
, as the previous constants didn't match the WebSockets specs #1580.v0.19.0
: Version 0.19.0Compare Source
Added
headers
parameter toHTTPException
#1435.405
status code insert anAllow
header, as described by RFC 7231 #1436.content
argument inJSONResponse
is now required #1431.FileResponse
#1266.raw_path
toTestClient
scope #1445.MutableHeaders
#1240.anyio
required version range to>=3.4.0,<5.0
#1421 and #1460.typing-extensions>=3.10
requirement - used only on lower versions than Python 3.10 #1475.Fixed
BaseHTTPMiddleware
from hiding errors ofStreamingResponse
and mounted applications #1459.SessionMiddleware
uses an explicitpath=...
, instead of defaulting to the ASGI 'root_path' #1512.Request.client
is now compliant with the ASGI specifications #1462.KeyError
at early stage for missing boundary #1349.Deprecated
run_until_first_complete
#1443.v0.18.0
: Version 0.18.0Compare Source
Added
FileResponse
#1345.functools.partial
inWebSocketRoute
#1356.StaticFiles
packages with directory #1350.Jinja2Templates
#1401.HttpEndpoint
#1346.websocket.accept
message #1361 and #1422.reason
toWebSocket
close ASGI event #1417.UploadFile
#1382.Content-Length
header forContent-Length: 0
cases #1395.SessionMiddleware.max_age
now acceptsNone
, so cookie can last as long as the browser session #1387.Fixed
hashlib.md5()
function onFileResponse
s ETag generation. The parameterusedforsecurity
flag is set toFalse
, if the flag is available on the system. This fixes an error raised on systems with FIPS enabled #1366 and #1410.path_params
type onurl_path_for()
method i.e. turnstr
intoAny
#1341.Host
now ignoresport
on routing #1322.v0.17.1
: Version 0.17.1Compare Source
Fixed
IndexError
in authenticationrequires
when wrapped function arguments are distributed between*args
and**kwargs
#1335.v0.17.0
: Version 0.17.0Compare Source
Added
Response.delete_cookie
now accepts the same parameters asResponse.set_cookie
#1228.Jinja2Templates
constructor to allowPathLike
#1292.Fixed
HTTPConnection.__getitem__
return type fromstr
totyping.Any
#1118.ImmutableMultiDict.getlist
return type fromtyping.List[str]
totyping.List[typing.Any]
#1235.OSError
exceptions onStaticFiles
#1220.StaticFiles
404.html in HTML mode #1314.Removed
v0.16.0
: Version 0.16.0Compare Source
Added
#1219
Fixed
starlette.websockets.WebSocket
instances are now hashable and compare by identity#1039
#1213,
#1227
Deprecated/removed
starlette.templates.Jinja2Templates.get_env
was removed#1218
starlette.testclient.TestClient.async_backend
was removed,the backend is now configured using constructor kwargs
#1211
starlette.router.Router(lifespan_context=)
is deprecated. You should wrap your lifespan in@contextlib.asynccontextmanager
.#1227
#1110
v0.15.0
: Version 0.15.0Compare Source
0.15.0
This release includes major changes to the low-level asynchronous parts of Starlette. As a result, Starlette now depends on AnyIO and some minor API changes have occurred. Another significant change with this release is the deprecation of built-in GraphQL support.
Added
TestClient.websocket_connect()
now must be used as a context manager.GZipMiddleware
is now adjustable - #1128.Fixed
CORSMiddleware
. See #1111, #1112, #1113, #1199.RedirectResponse
now usesquote
instead ofquote_plus
encoding for theLocation
header to better match the behaviour in other frameworks such as Django - #1164.BaseHTTPMiddleware
when handling large responses - #1012 fixed via #1157Deprecated/removed
GraphQLApp
class has been deprecated and will be removed in a future release. Please see #619. GraphQL is not supported on Python 3.10.executor
parameter toGraphQLApp
was removed. Useexecutor_class
instead.workers
parameter toWSGIMiddleware
was removed. This hasn't had any effect since Starlette v0.6.3.v0.14.2
: Version 0.14.2Compare Source
Fixed
ServerErrorMiddleware
compatibility with Python 3.9.1/3.8.7 when debug mode is enabled - #1132.ResourceWarning
s when using theTestClient
with WebSocket endpoints - #1132.async
endpoints wrapped infunctools.partial
on Python 3.8+ - #1106.v0.14.1
: Version 0.14.1Compare Source
Removed
UJSONResponse
was removed (this change was intended to be included in 0.14.0). Please see the documentation for how to implement responses using custom JSON serialization - #1074.v0.14.0
: Version 0.14.0Compare Source
Added
StreamingResponse
, allow custom async iterator such as objects from classes implementing__aiter__
.functools.partial
async handlers in Python versions 3.6 and 3.7.Changed
asyncio.wait
.format_exception
instead offormat_tb
inServerErrorMiddleware
'sdebug
responses.requires
decorator.Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.