Add Emote events #244
Draft
Add Emote events #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are intended for foreground apps to signal to other components (for example hexpansion drivers) that something interesting, good or bad, happened in the user interface, so that the other component can present that in its own way to the user. Guidelines for use: Only send emotes when you are the foreground app: these events are intended to be UI output like writing to the screen is. Send at most a handful of emotes per minute. These events might generate relatively long behaviours on the order of a few seconds, for example playing a short jingle on an audio hexpansion.
Not tested: the app store, because it isn't working for me The sponsor one maybe shouldn't stay around - it's not like there's any actual good UI happening here
This is not intended for immediate merge into the main tree. But I wanted to have some demo to iterate on of what emote events could do. This commit I'm interested in other people's feedback on if/how the default LEDs should do emotes. Behaviour now: back leds flash: red for negative, green for positive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These are intended for foreground apps to signal to other components (for example hexpansion drivers) that something interesting, good or bad, happened in the user interface, so that the other component can present that in its own way to the user.
This PR has three commits:
The app and driver commits are more for discussion about what any default emote behaviour should be rather than immediate merge.
I will also open a separate PR with only the event definitions, intended for actual merge.
Guidelines for use:
Only send emotes when you are the foreground app: these events are intended to be UI output like writing to the screen is.
Send at most a handful of emotes per minute. These events might generate relatively long behaviours on the order of
a few seconds, for example playing a short jingle on an audio hexpansion.