Add support to implement Apple Watch screenshot#28
Open
PPacie wants to merge 20 commits intoemilbaehr:masterfrom
Open
Add support to implement Apple Watch screenshot#28PPacie wants to merge 20 commits intoemilbaehr:masterfrom
PPacie wants to merge 20 commits intoemilbaehr:masterfrom
Conversation
Fix apple watch image margin for smaller mobile screen.
Owner
|
Hi there! This looks really nice. I'm very sorry for not looking into this earlier. I'll try to merge the pull request in the next coming days. Thanks for the nice work. |
|
Hi @emilbaehr, Do you have an ETA for merging this PR? I would love to use this project for my Apple Watch app. 😊 Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey Emil,
Thanks again for sharing this project with the community.
I have implemented support to add an Apple Watch screenshot if by setting
enable_apple_watch = truein_config.yml.The procedure is the same as for adding an iPhone screenshot.
Supported screenshot sizes are:
I've included a demo screenshot.
You can see/test it live on my website buoywatch.com.
I believe that most of the part of the implementation code is ok. However, I am an iOS dev (I don't do web). Sorry, if the CSS or anything I've touched is not 100% correct. Feel free to adjust it.
PS: Your code was pretty clean and well structure that even a non web developer could implement a new feature on it =)
Cheers,
Pablo.