Add comment for macOS users of fill_template.sh#187
Closed
saurabhkaul wants to merge 3 commits intoemilk:mainfrom
Closed
Add comment for macOS users of fill_template.sh#187saurabhkaul wants to merge 3 commits intoemilk:mainfrom
saurabhkaul wants to merge 3 commits intoemilk:mainfrom
Conversation
Contributor
|
I think providing at least one way is better. If you now how to do the nix approach you can mention both. |
c-git
reviewed
Apr 3, 2025
| Alternatively, you can run `fill_template.sh` which will ask for the needed names and email and perform the above patches for you. This is particularly useful if you clone this repository outside GitHub and hence cannot make use of its | ||
| templating function. | ||
|
|
||
| (macOS users will need to install GNU sed first for the script to work, if you're using Homebrew you can use `brew install gnu-sed` and then add it to your path `PATH="/usr/local/opt/gnu-sed/libexec/gnubin:$PATH") |
Contributor
There was a problem hiding this comment.
You might want an empty line before the next heading.
Author
|
@emilk Would love your thoughts here |
Collaborator
|
Thanks! But it'd of course be better for the script to just work on macOS, I opened a fix here: #188 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #164 by adding a comment for macOS users in the README, as mentioned as a possible solution in the Issue.
However, I'm open to further ideas, right now this feels like the lowest hanging fruit.
Also, this explicitly refers to the homebrew method of adding gnused in macOS, while there are other ways too (like using nix for example), so should we keep it or should we let the user figure out how they wanna install gnused on their machine?