Make initial setup simpler #6
Conversation
Fixes issue where highlight.js incorrectly guesses the wrong language
Made starting template.html a better initial experience by adding expected tags. * Added `html`, `head`, `meta`, and `body` tags. * HTML5 doctype included. * Wrapped markup examples in `code` tags, allowing for more accurate examples. * pre > code styles added to allow overflow scrolling.
Exposing the marked node-module options to the user but enforcing custom renderer.
|
Upon reviewing the readme of this project, this may go against the initial intention — html that you can copy into a cms WITHIN your site rather than being a standalone file. I'll leave it up to you @emiloberg if you want to merge this change or not. I've found it useful to keep this style guide as a static, self-contained file, but that's just my use-case. |
|
Really nice @Cleecanth! Commit 84f2638 and c78ed92 are great. I'll gratefully accept them. About the initial template (84f2638). Yeah my initial intention for this small tool is generate a style guide which lives within the cms/site/like. There are a bunch of tools which generates stand alone style guides (styledown being one which this project has drawn a lot of inspiration from). Thing is, even if you include full html ( As it goes against the intentions of the tool I don't really want to include it in the standard template. One way to go about it could be to include a I propose this: If you want to, revert commit c59de37 (but feel very free to re-add the pre styling and javascript-at-end-of-file stuff) and I'll merge it as is. And if we come to any smart conclusions about the html file thing we handle that separate. Again: Nice work! Thanks! |
|
(I'll be out away from internet for a couple of days but I'll get back to you as soon as possible) |
|
This PR was really helpful for me just to have a better understanding of how everything works, so thank you anyway even if it's not merged! |
3 participants
It makes sense to give this a sort of boilerplate treatment, so here's some things that should help:
<head>makes this much more clear....which also allows for horizontal scrolling on very long lines of code.