Add an API to allow mods to do their own EMI searching#496
Open
embeddedt wants to merge 4 commits intoemilyploszaj:1.20.4from
Open
Add an API to allow mods to do their own EMI searching#496embeddedt wants to merge 4 commits intoemilyploszaj:1.20.4from
embeddedt wants to merge 4 commits intoemilyploszaj:1.20.4from
Conversation
emilyploszaj
requested changes
Mar 30, 2024
Owner
emilyploszaj
left a comment
emilyploszaj
left a comment
There was a problem hiding this comment.
I haven't done as thorough a review as I'd like as I do not currently have the time, but I have gone through and pointed out some initial things I noticed.
xplat/src/main/java/dev/emi/emi/api/search/EmiSearchManagerApi.java
Outdated
Show resolved
Hide resolved
xplat/src/main/java/dev/emi/emi/api/search/EmiSearchManagerApi.java
Outdated
Show resolved
Hide resolved
xplat/src/main/java/dev/emi/emi/api/search/EmiSearchManagerApi.java
Outdated
Show resolved
Hide resolved
|
is this still being worked on? |
Owner
|
It has been shelved a bit due to a lack of need on modern versions. It may be revisited when there is more time |
|
is this being worked on? it would be cool to have that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to add an API so that mods can run their own EMI search queries without changing the contents of the global search bar. (The motivation for this change is to add support for EMI to ModernFix's creative search tree optimization, which skips vanilla's search tree creation and just uses the installed recipe viewer to do the searching instead.)
To do this, some static fields were refactored into a "search manager" object. EMI's screen manager holds one instance of such an object, and mods may create their own via
EmiApi.createSearchManager().The code may need some quality improvement work, and an outstanding question is whether some guard needs to be added to stall searches until
EmiSearch.bake()has finished running.