Add ability to disable tooltip indexing#788
Open
embeddedt wants to merge 1 commit intoemilyploszaj:1.21from
Open
Add ability to disable tooltip indexing#788embeddedt wants to merge 1 commit intoemilyploszaj:1.21from
embeddedt wants to merge 1 commit intoemilyploszaj:1.21from
Conversation
Owner
|
Notable perf improvement, but I think this is maybe an antifeature. Instead of having users disable features for better performance, perhaps search baking should be off of the reload thread like recipe baking falling back to manual matching (or simply not allowing search)? I can look into an implementation of this, I think I'd probably want my hands on it. What do you think? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reading the tooltips of modded items can be slow since many mods have relatively inefficient tooltip handlers. This PR adds an option to disable that, at the cost of preventing tooltips from being searched at all. The default is to still index tooltips.