Do not retain JEMI layout builder for every recipe#951
Merged
emilyploszaj merged 1 commit intoemilyploszaj:1.21from May 17, 2025
Merged
Do not retain JEMI layout builder for every recipe#951emilyploszaj merged 1 commit intoemilyploszaj:1.21from
emilyploszaj merged 1 commit intoemilyploszaj:1.21from
Conversation
Owner
|
Well this seems like a really funny oversight, thanks for finding it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
builderfield ofJemiRecipeis only ever referenced during the constructor, and appears to just be used to compute the inputs/outputs/catalysts of the recipe. To actually render the recipe a new builder is created inaddWidgets. Therefore it seems there's no need to retain this temporary initial builder in a field forever. Removing it substantially reduces the retained size ofJemiRecipes in a modpack.