Skip to content

🔖 Search Bookmarks#959

Open
rubybrowncoat wants to merge 3 commits intoemilyploszaj:1.21from
rubybrowncoat:feature/bookmarks
Open

🔖 Search Bookmarks#959
rubybrowncoat wants to merge 3 commits intoemilyploszaj:1.21from
rubybrowncoat:feature/bookmarks

Conversation

@rubybrowncoat
Copy link

@rubybrowncoat rubybrowncoat commented May 17, 2025

This adds a new Panel/Sidebar that allows users to save their search queries for quick reuse.

This for example is how I'm currently using it:
image

@emilyploszaj
Copy link
Owner

Do not call this feature "bookmarks", that's already a nickname for favorites, there is no reason this should be exposed to the API, please provide a better visualization method than a cycling ingredient, please adjust your type to not crash by returning null for no reason.

Additionally, is this a good solution for problems? EMI already saves recent searches and can cycle through them with up and down on the keyboard, desired stacks can be favorited and sorted manually, and the UI is optimized for this. Is there actually a reasonable use case that would justify a player adding a new sidebar just for search history? Is this even worth the implementation and maintenance burden?

@ICaxapI
Copy link

ICaxapI commented Dec 29, 2025

In defense of this functionality, I can say that in technical builds, it's very convenient to save favorite bookmarks for certain complex searches, such as those related to processing different ores, to quickly switch between them when needed. For example, I could forget what variants were available for the copper I processed six months ago and simply apply the search I set up back then with one click.
By the way, it would be convenient if this search processed regular expressions.

@Mickeon
Copy link

Mickeon commented Mar 4, 2026

EMI already saves recent searches and can cycle through them with up and down on the keyboard

It may likely be some other obscure mod conflicting with this, but pressing up and down while focusing on the search bar does nothing in my modpack.
EMI 1.1.22+1.21.1+neoforge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants