Fix potential deadlock in PyFutureAwaitable callback dispatch#802
Merged
gi0baro merged 2 commits intoemmett-framework:masterfrom Feb 8, 2026
Merged
Fix potential deadlock in PyFutureAwaitable callback dispatch#802gi0baro merged 2 commits intoemmett-framework:masterfrom
gi0baro merged 2 commits intoemmett-framework:masterfrom
Conversation
Member
|
I'm prone to consider this as a random effect, other than the actual solution. I'm not exactly sure how the
I'm going to still review the code and possibly merge it, as it might be a valid concern for the free-threaded builds, but again, it's hard to think this can be the actual solution on whatever the problem in #750 is, and more like a coincidence. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #750
Reproduction of the issue can be found at: https://github.com/ColemanDunn/granian-channels-lock-up
Change is to not hold the RwLock across
call_soon_threadsafe. The comment is somewhat self documenting of what this change does. I can take it out if needed. Perhaps there is a better fix than this in the underlying code, but I am now unable to reproduce the lockup.