Access log vars - #829
Conversation
|
@gi0baro ready for review, thanks |
|
hi @gi0baro , I would also love to have this feature to put it on parity with gunicorn. any progress on this MR? |
|
@nitrag does this address the |
|
@nalundgaard I believe there was additional overhead with adding body/content length, so I removed it. I'm hoping this PR is low enough impact so it has higher chance of being merged. |
|
Hey all, please stop pinging me. A lot happened in my personal life in the past few months – and even if this wasn't the case – give me the time to appropriately review stuff. |
1d527e8 to
43115e9
Compare
gi0baro
left a comment
There was a problem hiding this comment.
I refactored this, specifically:
- dropped response headers entirely, too much complexity added for a limited use-case
- use
%(header{Header-Name})sas the atom, every other atom is not compatible with Gunicorn, thus no reason to use the same fmt just for this one - removed
user-agentas a special case, it's an header like everything else - split all the code paths for header vs non-header cases
- dropped tests, I don't see the value gain on an already slow suite
- updated README accordingly
Refers to #312
Add support for arbitrary request headers in access log via
%(header{Header-Name})satom