First version of added namespace search in get_by_label #838
Conversation
jesper-friis
left a comment
jesper-friis
left a comment
There was a problem hiding this comment.
See the comments.
The tests are failing, but I guess that the purpose of PR #839 is to fix them.
|
This PR has never been ready for review. will close all comments for now.
This PR has never been ready for review. will close all comments for now. |
| ) | ||
| namespace = splitlabel[0] | ||
|
|
||
| #print('namespace', namespace) |
|
|
||
| #print('namespace', namespace) | ||
| if namespace: | ||
| #print('in get_by_label namespavce') |
| #print("in namespace", namespace) | ||
| #print("entities", entities) | ||
| #for ent in entities: | ||
| # print("ent.namespace", ent.namespace) | ||
| # print("ent.namespace.name", ent.namespace.name) | ||
| # print("namespace", namespace) | ||
| # print(namespace in [ent.namespace.name, ent.namespace.base_iri]) |
| exact_match: Do not treat "*" and brackets as special characters | ||
| when matching. May be useful if your ontology has labels | ||
| containing such labels. | ||
| label: label so search for. |
There was a problem hiding this comment.
looks like an extra indentation
| return 2 * ccadepth / (generations1 + generations2 + 2 * ccadepth) | ||
|
|
||
| def new_entity( | ||
| def new_entity( # pylint: disable=too-many-arguments,too-many-branches,too-many-positional-arguments |
There was a problem hiding this comment.
These pylint disable's will probably make the line too long. Probably better to move the comment to after the docstring (line 2119)
jesper-friis
left a comment
jesper-friis
left a comment
There was a problem hiding this comment.
There are some conflicts and failing tests that must be fixed.
I see that one of the tests fails with that emmo.hasPart doesn't exists. That should be there. Can there be something wrong in the changes in get_by_label()?
Description
Type of change
Checklist
This checklist can be used as a help for the reviewer.
Comments