Skip to content

Conversation

@jesper-friis
Copy link
Collaborator

@jesper-friis jesper-friis commented Nov 29, 2025

Description

Prevent ontoconvert from crashing unintentionally when the --iri option is given.

Include also some minor code cleanup.

Type of change

  • Bug fix.
  • New feature.
  • Documentation update.
  • Test update.

Checklist

This checklist can be used as a help for the reviewer.

  • Is the code easy to read and understand?
  • Are comments for humans to read, not computers to disregard?
  • Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
  • Has the documentation been updated as necessary?
  • Does this close the issue?
  • Is the change limited to the issue?
  • Are errors handled for all outcomes?
  • Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments

@jesper-friis jesper-friis marked this pull request as draft November 29, 2025 13:39
@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.05%. Comparing base (65e2b6c) to head (00ec1b7).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #902   +/-   ##
=======================================
  Coverage   73.05%   73.05%           
=======================================
  Files          19       19           
  Lines        3919     3919           
=======================================
  Hits         2863     2863           
  Misses       1056     1056           
Flag Coverage Δ
unittests 73.05% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jesper-friis jesper-friis marked this pull request as ready for review December 1, 2025 17:24
@jesper-friis jesper-friis changed the title Improve annotation of ontologies Prevent ontoconvert from crashing when the --iri option is given Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants