fix: Add missing @emotion/react peer dependency to native and primitives packages(#3351)#3357
Open
SeoJaeWan wants to merge 3 commits intoemotion-js:mainfrom
Open
fix: Add missing @emotion/react peer dependency to native and primitives packages(#3351)#3357SeoJaeWan wants to merge 3 commits intoemotion-js:mainfrom
@emotion/react peer dependency to native and primitives packages(#3351)#3357SeoJaeWan wants to merge 3 commits intoemotion-js:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 1966617 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
SeoJaeWan
changed the title
@emotion/react peer dependency to native and primitives packages@emotion/react peer dependency to native and primitives packages
SeoJaeWan
changed the title
@emotion/react peer dependency to native and primitives packages@emotion/react peer dependency to native and primitives packages(#3351)
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Add
@emotion/reactas a peer dependency to@emotion/nativeand@emotion/primitivespackages.Why:
Fixes #3351
Both
@emotion/nativeand@emotion/primitivesdepend on@emotion/primitives-core, which requires@emotion/reactas a peer dependency (it importsThemeContextfrom@emotion/react). However, neither package declared this transitive peer dependency, causing npm/yarn to not warn users when@emotion/reactis missing.How:
@emotion/react: ^11.0.0-rc.0topeerDependenciesinpackages/native/package.jsonreact: >=16.8.0topeerDependenciesinpackages/native/package.json(was also missing)@emotion/react: ^11.0.0-rc.0topeerDependenciesinpackages/primitives/package.jsonThese version ranges match the peer dependency declarations in
@emotion/primitives-coreand@emotion/styled.Checklist: