Fix layout issues with the sidenav#8
Open
alexeykostevich wants to merge 3 commits intoempress:masterfrom
alexeykostevich:master
Open
Fix layout issues with the sidenav#8alexeykostevich wants to merge 3 commits intoempress:masterfrom alexeykostevich:master
alexeykostevich wants to merge 3 commits intoempress:masterfrom
alexeykostevich:master
Conversation
Author
|
@mansona , please, let me know if you have any concerns about the PR or its relevancy. |
MelSumner
approved these changes
Apr 26, 2020
MelSumner
left a comment
MelSumner
left a comment
There was a problem hiding this comment.
This seems like it will fix the issues we were seeing with the overlapping content, although it would be great to figure it out (as an iteration) without using z-index or absolute positioning. :) Thank you for contributing @alexeykostevich ! 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
z-indexin documented components (fixes styleguide rendering issue ember-learn/ember-styleguide#286).