Draft
Conversation
savonarola
commented
Oct 9, 2025
| ManagedEnv::ManagedEnv(rocksdb::Env* env, std::shared_ptr<rocksdb::Env> guard_env) : env_(env), guard_env_(guard_env) {} | ||
|
|
||
| ManagedEnv::~ManagedEnv() | ||
| { |
Author
There was a problem hiding this comment.
The destructor was actually never called 🤷
Simple memenv creation and destruction was eating memory constantly
Fn = fun F() -> spawn(fun() -> {ok, Env} = rocksdb:new_env(memenv), rocksdb:destroy_env(Env) end), F() end, Fn().
savonarola
commented
Oct 9, 2025
|
|
||
|
|
||
| ERL_NIF_TERM | ||
| DestroyEnv( |
Author
There was a problem hiding this comment.
This function seems useless, why is it needed at all?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is not for merging, it is investigation how we may keep data encrypted
Building and running
Install rocksdb deps as system packages, e.g.
Clone and checkout
rocksdbat 8.x version, cloneencfspluginBuild with system libs and with PIC
Checkout
erlang-rocksdbatenc-pluginbranchBuild linking with the compiled rocksdb and dynamically linking with all the deps:
Run tests:
encfs tests should succeed: