feat: implement optional compression based on threshold #54
Conversation
edgurgel
force-pushed
the
feat/compression
branch
from
eb7f8bd to
3b761cd
Compare
edgurgel
force-pushed
the
feat/compression
branch
from
3b761cd to
05d2ae3
Compare
|
I wonder if " Size = erlang:external_size(Term)" line can penalize performance when sending a lot of small objects. Maybe this calculation can be omitted when |
Yup I can do that! From our benchmarks |
src/gen_rpc_helper.erl
Outdated
| {ok, Compress} = application:get_env(?APP, compress), | ||
| do_term_to_iovec(Term, Compress). | ||
|
|
||
| do_term_to_iovec(Term, Compress) when is_integer(Compress), Compress >= 1 -> |
There was a problem hiding this comment.
Please move this function to "Private functions" section.
src/gen_rpc_helper.erl
Outdated
|
|
||
| do_term_to_iovec(Term, Compress) when is_integer(Compress), Compress >= 1 -> | ||
| {ok, CompressionThreshold} = application:get_env(?APP, compression_threshold), | ||
|
|
There was a problem hiding this comment.
Please remove empty lines in the function bodies or replace them with comments.
Two new options: * compress: A number (default = 0) from 0 to 9 to define level of compression. * compression_threshold: The minimum amount of bytes (default = 1024) needed to be worth compressing the TCP message sent.
Co-authored-by: ieQu1 <[email protected]>
edgurgel
force-pushed
the
feat/compression
branch
from
4241656 to
7ff7b63
Compare
|
Ok! I've rebased the branch with master and I think I've addressed all comments 🙇 |
edgurgel
force-pushed
the
feat/compression
branch
from
7ff7b63 to
b3fe872
Compare
2 participants
Two new options:
We have been using this for months in production 👍 . It's specially useful when casts are batched with
max_batch_size > 0