feat: include abcast as part of the cast batch

[edgurgel]

Also added a couple of tests for batches

[ieQu1]

Thanks for the PR. I'll take a closer look later. Note: we're currently using this library only for ordered casts. Other features are very much unmaintained. I don't recommend using this library for new projects.

[edgurgel]

Thanks for the PR. I'll take a closer look later. Note: we're currently using this library only for ordered casts. Other features are very much unmaintained. I don't recommend using this library for new projects.

Too late 😆. We are using all features and having absolutely no issues!

Out of curiosity... what did you end up using in lieu of gen_rpc (if you don't mind talking about it)?

[ieQu1]

Out of curiosity... what did you end up using in lieu of gen_rpc (if you don't mind talking about it)?

gen_rpc was added to EMQX long time ago, when Erlang distribution protocol was suffering from head-of-line blocking. Because of that, intense MQTT traffic forwarding between broker nodes would introduce RPC latency to other applications, notably Mnesia. In the later OTP versions they introduced packet slicing, so this problem has become less severe, and we started to move away from Mnesia too. We still use gen_rpc to forward payloads, but this is done using async_cast and call API. Hence, these are the only parts of the application that I coverered by tests (original code was quite sparse in that regard).

[edgurgel]

Thanks for the explanation 🙇