Commit 0167321
authored
Lift the previous 100 max workers limit (#25410)
A long time ago, Firefox had a default limit of
`dom.workers.maxPerDomain == 20`, and a hardcoded cap of
`navigator.hardwareConcurrency` reporting 16 even on systems that would
have more hardware threads.
To work around those limits for Emscripten tests that hammered lots of
Workers, we had bumped the default `dom.workers.maxPerDomain` limit from
20 up to 100.
In [August
2016](mozilla-firefox/firefox@f6650e8#diff-8c2c5665d52eb6026c4017acc0c311c6d9cc6b2b8719f50c1539ee836f2ea361R97-R114),
Firefox itself bumped the same default limit of
`dom.workers.maxPerDomain` from 20 up to 512.
Then in April of this year, Firefox [lifted the hardcoded
cap](mozilla-firefox/firefox@af05ed3)
of `navigator.hardwareConcurrency` from 16 up to 128.
This means that the limit `user_pref("dom.workers.maxPerDomain", 100);`
we now have is too small, and on a 256-thread workstation, caused
attempting to spawn >100 Workers in the Pthread pool to hang, as 128
concurrent Workers would not be allowed.
So remove the previous 100 max workers limit. Explicitly bump it up to
the same default limit 512 that Firefox has to make the limit go away in
testing older browsers as well.
Fixes e.g. `browser.test_pthread_hardware_concurrency` on >128-thread
workstations.1 parent 27d725b commit 0167321
2 files changed
+6
-4
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
229 | 229 | | |
230 | 230 | | |
231 | 231 | | |
232 | | - | |
233 | | - | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
234 | 235 | | |
235 | 236 | | |
236 | 237 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | | - | |
| 1 | + | |
| 2 | + | |
| 3 | + | |
3 | 4 | | |
4 | 5 | | |
5 | 6 | | |
| |||
0 commit comments