Skip to content

Commit 1fe2dfa

Browse files
authored
Use getFullscreenElement over legacy fullscreen attribute. NFC (#24712)
The getFullscreenElement utility has fallbacks for old browsers going back as far as we support. See https://caniuse.com/mdn-api_document_fullscreenelement
1 parent 455ad34 commit 1fe2dfa

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/lib/libglfw.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -632,7 +632,7 @@ var LibraryGLFW = {
632632
var resizeNeeded = false;
633633

634634
// If the client is requesting fullscreen mode
635-
if (document["fullscreen"] || document["fullScreen"] || document["mozFullScreen"] || document["webkitIsFullScreen"]) {
635+
if (getFullscreenElement()) {
636636
if (!GLFW.active.fullscreen) {
637637
resizeNeeded = width != screen.width || height != screen.height;
638638
GLFW.active.storedX = GLFW.active.x;

src/lib/libglut.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
*/
66

77
var LibraryGLUT = {
8-
$GLUT__deps: ['$Browser', 'glutPostRedisplay'],
8+
$GLUT__deps: ['$Browser', '$getFullscreenElement', 'glutPostRedisplay'],
99
$GLUT: {
1010
initTime: null,
1111
idleFunc: null,
@@ -279,7 +279,7 @@ var LibraryGLUT = {
279279
onFullscreenEventChange: (event) => {
280280
var width;
281281
var height;
282-
if (document["fullscreen"] || document["fullScreen"] || document["mozFullScreen"] || document["webkitIsFullScreen"]) {
282+
if (getFullscreenElement()) {
283283
width = screen["width"];
284284
height = screen["height"];
285285
} else {

0 commit comments

Comments
 (0)