Skip to content

Commit 455ad34

Browse files
authored
Run wasm2js2.test_pthread_proxying as part of CI. NFC (#24720)
This confirms that wasm2js + pthreads + closure compiler are compatible. See #16706. I believe this issues was likely fixed when we removed the separate worker.js file. Replaces: #24719 Fixes: #16706
1 parent cd0467f commit 455ad34

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

.circleci/config.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -600,6 +600,7 @@ jobs:
600600
core2s.test_module_wasm_memory
601601
cores.test_minimal_runtime_safe_heap
602602
wasm2js3.test_memorygrowth_2
603+
wasm2js2.test_pthread_proxying
603604
wasmfs.test_hello_world
604605
wasmfs.test_unistd_links*
605606
wasmfs.test_atexit_standalone

test/test_core.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -437,6 +437,9 @@ def setup_esm_integration(self):
437437
def maybe_closure(self):
438438
if '--closure=1' not in self.cflags and self.should_use_closure():
439439
self.cflags += ['--closure=1']
440+
if self.is_wasm2js():
441+
# wasm2js output currently contains closure warnings
442+
self.cflags += ['-Wno-closure']
440443
logger.debug('using closure compiler..')
441444
return True
442445
return False

0 commit comments

Comments
 (0)