Fix issue with windows + braces in path (#24717)

Fixes: #24713

Author: sbc100

.circleci/config.yml

@@ -1056,7 +1056,10 @@ jobs:
   # windows and mac do not have separate build and test jobs, as they only run
   # a limited set of tests; it is simpler and faster to do it all in one job.
   test-windows:
-    working_directory: "~/path with spaces"
+    # Use spaces and other special chars in the path to emsdk to flush out
+    # issues with windows.  In particular, the .bat file launches can have
+    # trouble with these.
+    working_directory: "~/path with spaces ()/"
     executor:
       name: win/server-2019
       shell: bash.exe -eo pipefail

bootstrap.bat

@@ -23,7 +23,7 @@
 :: %~dp0 expansions will not work.
 :: So first try if %~dp0 might work, and if not, manually look up this script from PATH.
 @if exist "%~f0" (
-  set MYDIR=%~dp0
+  set "MYDIR=%~dp0"
   goto FOUND_MYDIR
 )
 @for %%I in (%~n0.bat) do (

em++.bat

@@ -23,7 +23,7 @@
 :: %~dp0 expansions will not work.
 :: So first try if %~dp0 might work, and if not, manually look up this script from PATH.
 @if exist "%~f0" (
-  set MYDIR=%~dp0
+  set "MYDIR=%~dp0"
   goto FOUND_MYDIR
 )
 @for %%I in (%~n0.bat) do (

em-config.bat

@@ -23,7 +23,7 @@
 :: %~dp0 expansions will not work.
 :: So first try if %~dp0 might work, and if not, manually look up this script from PATH.
 @if exist "%~f0" (
-  set MYDIR=%~dp0
+  set "MYDIR=%~dp0"
   goto FOUND_MYDIR
 )
 @for %%I in (%~n0.bat) do (

emar.bat

@@ -23,7 +23,7 @@
 :: %~dp0 expansions will not work.
 :: So first try if %~dp0 might work, and if not, manually look up this script from PATH.
 @if exist "%~f0" (
-  set MYDIR=%~dp0
+  set "MYDIR=%~dp0"
   goto FOUND_MYDIR
 )
 @for %%I in (%~n0.bat) do (

embuilder.bat

@@ -23,7 +23,7 @@
 :: %~dp0 expansions will not work.
 :: So first try if %~dp0 might work, and if not, manually look up this script from PATH.
 @if exist "%~f0" (
-  set MYDIR=%~dp0
+  set "MYDIR=%~dp0"
   goto FOUND_MYDIR
 )
 @for %%I in (%~n0.bat) do (

emcc.bat

@@ -23,7 +23,7 @@
 :: %~dp0 expansions will not work.
 :: So first try if %~dp0 might work, and if not, manually look up this script from PATH.
 @if exist "%~f0" (
-  set MYDIR=%~dp0
+  set "MYDIR=%~dp0"
   goto FOUND_MYDIR
 )
 @for %%I in (%~n0.bat) do (

emcmake.bat

@@ -23,7 +23,7 @@
 :: %~dp0 expansions will not work.
 :: So first try if %~dp0 might work, and if not, manually look up this script from PATH.
 @if exist "%~f0" (
-  set MYDIR=%~dp0
+  set "MYDIR=%~dp0"
   goto FOUND_MYDIR
 )
 @for %%I in (%~n0.bat) do (

emconfigure.bat

@@ -23,7 +23,7 @@
 :: %~dp0 expansions will not work.
 :: So first try if %~dp0 might work, and if not, manually look up this script from PATH.
 @if exist "%~f0" (
-  set MYDIR=%~dp0
+  set "MYDIR=%~dp0"
   goto FOUND_MYDIR
 )
 @for %%I in (%~n0.bat) do (

emdwp.bat

@@ -23,7 +23,7 @@
 :: %~dp0 expansions will not work.
 :: So first try if %~dp0 might work, and if not, manually look up this script from PATH.
 @if exist "%~f0" (
-  set MYDIR=%~dp0
+  set "MYDIR=%~dp0"
   goto FOUND_MYDIR
 )
 @for %%I in (tools\emdwp.bat) do (