Skip to content

Commit 3bf9821

Browse files
authored
Enable test_hello_world_above_2gb. NFC (#18093)
1 parent 5ae1d7e commit 3bf9821

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

test/test_other.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12127,10 +12127,10 @@ def test_wasmfs_before_preload(self):
1212712127
self.emcc_args += ['--preload-file', 'js_backend_files/file.dat']
1212812128
self.do_run_in_out_file_test('wasmfs/wasmfs_before_preload.c')
1212912129

12130-
@disabled('Running with initial >2GB heaps is not currently supported on the CI version of Node')
12130+
# Requires v8 for now since the version of node we use in CI doesn't support >2GB heaps
12131+
@requires_v8
1213112132
def test_hello_world_above_2gb(self):
12132-
self.run_process([EMCC, test_file('hello_world.c'), '-sGLOBAL_BASE=2147483648', '-sINITIAL_MEMORY=3GB'])
12133-
self.assertContained('hello, world!', self.run_js('a.out.js'))
12133+
self.do_runf(test_file('hello_world.c'), 'hello, world!', emcc_args=['-sGLOBAL_BASE=2147483648', '-sINITIAL_MEMORY=3GB'])
1213412134

1213512135
def test_hello_function(self):
1213612136
# hello_function.cpp is referenced/used in the docs. This test ensures that it

0 commit comments

Comments
 (0)