Skip to content

Commit 59fd9b0

Browse files
committed
Bump min Firefox version to 68 ESR
1 parent b4a32f4 commit 59fd9b0

File tree

5 files changed

+6
-5
lines changed

5 files changed

+6
-5
lines changed

ChangeLog.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ See docs/process.md for more on how version tagging works.
2727
- Node: v10.19.0 -> v12.22.9
2828
- Chrome: v70 -> v74
2929
- Firefox: v55 -> v65
30+
- Minimum Firefox version was further bumped up to Firefox 68 ESR
3031
- The Embind `val` functions `call`, `operator()`, and `new_` now support
3132
passing `pointer`s by using the `allow_raw_pointers()` argument. This feature
3233
is only enabled with C++17 and newer. Older versions will allow pointers by

site/source/docs/tools_reference/settings_reference.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2871,7 +2871,7 @@ are desired to work. Pass -sMIN_FIREFOX_VERSION=majorVersion to drop support
28712871
for Firefox versions older than < majorVersion.
28722872
Firefox 79 was released on 2020-07-28.
28732873
MAX_INT (0x7FFFFFFF, or -1) specifies that target is not supported.
2874-
Minimum supported value is 65 which was released on 2019-01-29 (see
2874+
Minimum supported value is 68 which was released on 2019-07-09 (see
28752875
feature_matrix.py)
28762876

28772877
Default value: 79

src/settings.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1880,7 +1880,7 @@ var AUTO_NATIVE_LIBRARIES = true;
18801880
// for Firefox versions older than < majorVersion.
18811881
// Firefox 79 was released on 2020-07-28.
18821882
// MAX_INT (0x7FFFFFFF, or -1) specifies that target is not supported.
1883-
// Minimum supported value is 65 which was released on 2019-01-29 (see
1883+
// Minimum supported value is 68 which was released on 2019-07-09 (see
18841884
// feature_matrix.py)
18851885
// [link]
18861886
var MIN_FIREFOX_VERSION = 79;

test/test_other.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14335,8 +14335,8 @@ def test_min_browser_version(self):
1433514335
err = self.expect_fail([EMCC, test_file('hello_world.c'), '-Wno-transpile', '-Werror', '-sWASM_BIGINT', '-sMIN_SAFARI_VERSION=130000'])
1433614336
self.assertContained('emcc: error: MIN_SAFARI_VERSION=130000 is not compatible with WASM_BIGINT (MIN_SAFARI_VERSION=150000 or above required)', err)
1433714337

14338-
err = self.expect_fail([EMCC, test_file('hello_world.c'), '-Wno-transpile', '-Werror', '-pthread', '-sMIN_FIREFOX_VERSION=65'])
14339-
self.assertContained('emcc: error: MIN_FIREFOX_VERSION=65 is not compatible with pthreads (MIN_FIREFOX_VERSION=79 or above required)', err)
14338+
err = self.expect_fail([EMCC, test_file('hello_world.c'), '-Wno-transpile', '-Werror', '-pthread', '-sMIN_FIREFOX_VERSION=68'])
14339+
self.assertContained('emcc: error: MIN_FIREFOX_VERSION=68 is not compatible with pthreads (MIN_FIREFOX_VERSION=79 or above required)', err)
1434014340

1434114341
# Test that using two different ways to disable a target environment at the same time will not produce a warning.
1434214342
def test_double_disable_environment(self):

tools/feature_matrix.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
# N.b. when modifying these values, update comments in src/settings.js on
2424
# MIN_x_VERSION fields to match accordingly.
2525
OLDEST_SUPPORTED_CHROME = 74 # Released on 2019-04-23
26-
OLDEST_SUPPORTED_FIREFOX = 65 # Released on 2019-01-29
26+
OLDEST_SUPPORTED_FIREFOX = 68 # Released on 2019-07-09
2727
OLDEST_SUPPORTED_SAFARI = 120200 # Released on 2019-03-25
2828
# 12.22.09 is the oldest version of node that we do any testing with.
2929
# Keep this in sync with the test-node-compat in .circleci/config.yml.

0 commit comments

Comments
 (0)