More use of globalThis to save on code size. NFC (#25417)

Followup to #25381

Author: sbc100

src/cpuprofiler.js

@@ -756,7 +756,7 @@ function cpuprofiler_add_hooks() {
   emscriptenCpuProfiler.initialize();
 }
 
-if (typeof document != 'undefined') {
+if (globalThis.document) {
   emscriptenCpuProfiler.initialize();
 }
 

src/deterministic.js

@@ -20,7 +20,7 @@ Date.now = deterministicNow;
 // Setting performance.now to deterministicNow doesn't work so we instead
 // use a helper function in parseTools (getPerformanceNow()) to call it
 // directly.
-// if (typeof performance == 'object') performance.now = Date.now;
+// if (globalThis.performance) performance.now = Date.now;
 
 Module['thisProgram'] = 'thisProgram'; // for consistency between different builds than between runs of the same build
 

src/emrun_postjs.js

@@ -7,7 +7,7 @@
  * emcc is run with `--emrun`
  */
 
-if (typeof window == "object" && (typeof ENVIRONMENT_IS_PTHREAD == 'undefined' || !ENVIRONMENT_IS_PTHREAD)) {
+if (globalThis.window && (typeof ENVIRONMENT_IS_PTHREAD == 'undefined' || !ENVIRONMENT_IS_PTHREAD)) {
   var emrun_register_handlers = () => {
     // When C code exit()s, we may still have remaining stdout and stderr
     // messages in flight. In that case, we can't close the browser until all
@@ -89,7 +89,7 @@ if (typeof window == "object" && (typeof ENVIRONMENT_IS_PTHREAD == 'undefined' |
     http.send(data); // XXX  this does not work in workers, for some odd reason (issue #2681)
   };
 
-  if (typeof document != 'undefined') {
+  if (globalThis.document) {
     emrun_register_handlers();
   }
 }

src/emrun_prejs.js

@@ -8,7 +8,7 @@
  */
 
 // Route URL GET parameters to argc+argv
-if (typeof window == 'object') {
+if (globalThis.window) {
   Module['arguments'] = window.location.search.slice(1).trim().split('&');
   for (let i = 0; i < Module['arguments'].length; ++i) {
     Module['arguments'][i] = decodeURI(Module['arguments'][i]);

src/lib/libaddfunction.js

@@ -95,7 +95,7 @@ addToLibrary({
     // "WebAssembly.Function" constructor.
     // Otherwise, construct a minimal wasm module importing the JS function and
     // re-exporting it.
-    if (typeof WebAssembly.Function == "function") {
+    if (WebAssembly.Function) {
       return new WebAssembly.Function(sigToWasmTypes(sig), func);
     }
 #endif

src/lib/libatomic.js

@@ -22,7 +22,7 @@ addToLibrary({
   //   https://github.com/tc39/proposal-atomics-wait-async/blob/master/PROPOSAL.md
   // This polyfill performs polling with setTimeout() to observe a change in the
   // target memory location.
-  $polyfillWaitAsync__postset: `if (!Atomics.waitAsync || (typeof navigator != 'undefined' && navigator.userAgent && Number((navigator.userAgent.match(/Chrom(e|ium)\\/([0-9]+)\\./)||[])[2]) < 91)) {
+  $polyfillWaitAsync__postset: `if (!Atomics.waitAsync || (globalThis.navigator?.userAgent && Number((navigator.userAgent.match(/Chrom(e|ium)\\/([0-9]+)\\./)||[])[2]) < 91)) {
   let __Atomics_waitAsyncAddresses = [/*[i32a, index, value, maxWaitMilliseconds, promiseResolve]*/];
   function __Atomics_pollWaitAsyncAddresses() {
     let now = performance.now();
@@ -148,7 +148,7 @@ addToLibrary({
     return numCancelled;
   },
 
-  emscripten_has_threading_support: () => typeof SharedArrayBuffer != 'undefined',
+  emscripten_has_threading_support: () => !!globalThis.SharedArrayBuffer,
 
   emscripten_num_logical_cores: () =>
 #if ENVIRONMENT_MAY_BE_NODE

src/lib/libcore.js

@@ -1344,7 +1344,7 @@ addToLibrary({
     // (https://github.com/WebAudio/web-audio-api/issues/2527), so if building
     // with
     // Audio Worklets enabled, do a dynamic check for its presence.
-    if (typeof performance != 'undefined' && {{{ getPerformanceNow() }}}) {
+    if (globalThis.performance && {{{ getPerformanceNow() }}}) {
 #if PTHREADS
       _emscripten_get_now = () => performance.timeOrigin + {{{ getPerformanceNow() }}}();
 #else
@@ -1369,7 +1369,7 @@ addToLibrary({
     }
 #endif
 #if AUDIO_WORKLET // https://github.com/WebAudio/web-audio-api/issues/2413
-    if (typeof performance == 'object' && performance && typeof performance['now'] == 'function') {
+    if (globalThis.performance?.now == 'function') {
       return 1000; // microseconds (1/1000 of a millisecond)
     }
     return 1000*1000; // milliseconds
@@ -1383,7 +1383,7 @@ addToLibrary({
   // implementation is not :(
   $nowIsMonotonic__internal: true,
 #if AUDIO_WORKLET // // https://github.com/WebAudio/web-audio-api/issues/2413
-  $nowIsMonotonic: `((typeof performance == 'object' && performance && typeof performance['now'] == 'function'));`,
+  $nowIsMonotonic: `!!globalThis.performance?.now;`,
 #else
   // Modern environment where performance.now() is supported
   $nowIsMonotonic: 1,
@@ -2345,7 +2345,7 @@ addToLibrary({
     assert(id, 'addRunDependency requires an ID')
     assert(!runDependencyTracking[id]);
     runDependencyTracking[id] = 1;
-    if (runDependencyWatcher === null && typeof setInterval != 'undefined') {
+    if (runDependencyWatcher === null && globalThis.setInterval) {
       // Check for missing dependencies every few seconds
       runDependencyWatcher = setInterval(() => {
         if (ABORT) {

src/lib/libembind.js

@@ -1369,7 +1369,7 @@ var LibraryEmbind = {
 #endif
   ],
   $attachFinalizer: (handle) => {
-    if ('undefined' === typeof FinalizationRegistry) {
+    if (!globalThis.FinalizationRegistry) {
       attachFinalizer = (handle) => handle;
       return handle;
     }

src/lib/libeventloop.js

@@ -54,10 +54,10 @@ LibraryJSEventLoop = {
 
   $emSetImmediate__deps: ['$setImmediateWrapped', '$clearImmediateWrapped', '$emClearImmediate'],
   $emSetImmediate__postset: `
-    if (typeof setImmediate != "undefined") {
+    if (globalThis.setImmediate) {
       emSetImmediate = setImmediateWrapped;
       emClearImmediate = clearImmediateWrapped;
-    } else if (typeof addEventListener == "function") {
+    } else if (globalThis.addEventListener) {
       var __setImmediate_id_counter = 0;
       var __setImmediate_queue = [];
       var __setImmediate_message_id = "_si";
@@ -298,7 +298,7 @@ LibraryJSEventLoop = {
     },
 
     requestAnimationFrame(func) {
-      if (typeof requestAnimationFrame == 'function') {
+      if (globalThis.requestAnimationFrame) {
         requestAnimationFrame(func);
       } else {
         MainLoop.fakeRequestAnimationFrame(func);
@@ -340,8 +340,10 @@ LibraryJSEventLoop = {
       };
       MainLoop.method = 'rAF';
     } else if (mode == {{{ cDefs.EM_TIMING_SETIMMEDIATE}}}) {
-      if (typeof MainLoop.setImmediate == 'undefined') {
-        if (typeof setImmediate == 'undefined') {
+      if (!MainLoop.setImmediate) {
+        if (globalThis.setImmediate) {
+          MainLoop.setImmediate = setImmediate;
+        } else {
           // Emulate setImmediate. (note: not a complete polyfill, we don't emulate clearImmediate() to keep code size to minimum, since not needed)
           var setImmediates = [];
           var emscriptenMainLoopMessageId = 'setimmediate';
@@ -363,8 +365,6 @@ LibraryJSEventLoop = {
               postMessage({target: emscriptenMainLoopMessageId}); // In --proxy-to-worker, route the message via proxyClient.js
             } else postMessage(emscriptenMainLoopMessageId, "*"); // On the main thread, can just send the message to itself.
           });
-        } else {
-          MainLoop.setImmediate = setImmediate;
         }
       }
       MainLoop.scheduler = function MainLoop_scheduler_setImmediate() {

src/lib/libfs.js

@@ -1705,7 +1705,7 @@ FS.staticInit();`;
  #if FS_DEBUG
       dbg(`forceLoadFile: ${obj.url}`)
  #endif
-      if (typeof XMLHttpRequest != 'undefined') {
+      if (globalThis.XMLHttpRequest) {
         abort("Lazy loading should have been performed (contents set) in createLazyFile, but it was not. Lazy loading only works in web workers. Use --embed-file or --preload-file in emcc on the main thread.");
       } else { // Command-line.
         try {
@@ -1824,7 +1824,7 @@ FS.staticInit();`;
         }
       }
 
-      if (typeof XMLHttpRequest != 'undefined') {
+      if (globalThis.XMLHttpRequest) {
         if (!ENVIRONMENT_IS_WORKER) abort('Cannot do synchronous binary XHRs outside webworkers in modern browsers. Use --embed-file or --preload-file in emcc');
         var lazyArray = new LazyUint8Array();
         var properties = { isDevice: false, contents: lazyArray };