Use node's path.isAbsolute when running with a node fs #17821
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
This is also related to python/cpython#96509 CPython uses opendir to read files for import so it needs this to work in order for the node build to be portable. |
rchiodo
changed the title
Author
|
Sorry I didn't add any tests because I wasn't sure how to detect if on windows or not. If there's a way to do so, I think the |
Contributor
|
node's os module perhaps? |
Author
|
Sorry I meant in the |
…odo/emscripten into rchiodo/fix_node_path_isabs
Author
|
@tiran do you know who I might ping to get this reviewed? I managed to figure out how to add a windows only test. |
Author
Collaborator
|
I just opened an alternative PR for this at #17849. |
Author
|
Closing in favor of @kleisauke's #17849 |
kripken
pushed a commit
that referenced
this pull request
Nov 7, 2022
Ensures that absolute paths are handled correctly on Windows as well. Using these helpers should be safe, since binaries linked with -sNODERAWFS can only be used on Node.js, see: emscripten/src/library_noderawfs.js Line 28 in e98554f throw new Error("NODERAWFS is currently only supported on Node.js environment.") Context: #16296 Resolves: #17360. Resolves: #17819. Supersedes: #17821.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17819
Fixes problems with windows paths when running node builds on windows machines.