Switch to upstream freetype repo #18095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were previously pointing at a version_1 tag in our custom repo. This was basically VER-2.6 which a single patch applied. I can't see anything in that patch that is useful, perhaps this code didn't previously compile cleanly with emcc but today it seems to work just fine: emscripten-ports/FreeType@40a760c This seems like a good intermediate step before we actually do a freetype upgrade in #18088.
dschuff
approved these changes
Oct 24, 2022
kripken
approved these changes
Oct 24, 2022
sbc100
added a commit
that referenced
this pull request
Nov 14, 2022
This reverts commit ba3c10b. This change accidentally removed an emscripten patch to freetype. See: pyodide/pyodide#3239 (comment). Sadly we don't have a test for this patch so it wasn't picked up by our CI. I will work on adding a test so we can try to get this updated again in the future, but for now a quick revert makes the most sense.
sbc100
added a commit
that referenced
this pull request
Nov 15, 2022
This reverts commit ba3c10b. This change accidentally removed an emscripten patch to freetype. See: pyodide/pyodide#3239 (comment). Sadly we don't have a test for this patch so it wasn't picked up by our CI. I will work on adding a test so we can try to get this updated again in the future, but for now a quick revert makes the most sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were previously pointing at a
version_1tag in our custom repo. This was basicallyVER-2.6which a single patch applied.I can't see anything in that patch that is useful, perhaps this code didn't previously compile cleanly with emcc but today it seems to work just fine:
emscripten-ports/FreeType@40a760c
This seems like a good intermediate step before we actually do a freetype upgrade in #18088.