Node: always define __filename and __dirname in non-ES6 workers
#18397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Is |
Member
|
@kleisauke Yes, I just opened an issue for that, and disabled the test. (I also can't reproduce it locally.. very odd) |
In favor of `location.href`. This ensures we can remove those `ENVIRONMENT_IS_WORKER` specific guards. Alternative to commit 5decc70 introduced in PR emscripten-core#10343.
This failed with: ``` Aborted(Assertion failed: scriptDirectory (./) should be an absolute path) ```
kleisauke
force-pushed
the
simplify-script-dir-part1
branch
from
f247d18 to
b04fd51
Compare
RReverser
reviewed
Dec 22, 2022
RReverser
reviewed
Dec 22, 2022
kleisauke
force-pushed
the
simplify-script-dir-part1
branch
2 times, most recently
from
12a447b to
69553ef
Compare
This change was generated using: $ ./test/runner other.*code_size* other.*metadce* --rebase
kleisauke
force-pushed
the
simplify-script-dir-part1
branch
from
69553ef to
4b21f48
Compare
Collaborator
Author
|
Closing in favor of #24023. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In favor of
location.href. This ensures we can remove thoseENVIRONMENT_IS_WORKERspecific guards.Alternative to commit 5decc70 introduced in PR #10343.
This is a first step to unify/simplify the
_scriptDir/scriptDirectoryentanglement.Context: #17915.