[file-packager] Use fetch() for loading file packages.
#22016
Conversation
seanmorris
changed the title
fetch() for loading file packages.
sbc100
changed the title
fetch() for loading file packages.fetch() for loading file packages.
| }; | ||
| </script> | ||
| {{{ SCRIPT }}} | ||
| </body> |
There was a problem hiding this comment.
Rather than require special shell can you just rely on the fact that default reporting will try bot fetch and origFetch:
emscripten/test/browser_reporting.js
Line 16 in a6e1f5c
i.e. when you disable fetch you can cache the original fetch so that that browser reporting doesn't break.
There was a problem hiding this comment.
@sbc100 I'm not able to get the exception out of the browser without the custom shell. It just hangs with the exception listed as uncaught in the browser's console.
|
@seanmorris do you have some time up update this PR? I'd love to see it landing if possible. |
…ipten into sm-worker-package-fetch
NICE!!! |
Head branch was pushed to by a user without write access
…ipten into sm-worker-package-fetch
2 participants
This PR switches AJAX requests for file packages to be loaded with fetch() rather than XmlHttpRequest(). This allows service workers to make AJAX requests, since XmlHttpRequest is not available in service workers.
Module['setStatus']is now called with more granularity during package downloads.Previously, --embed-file was necessary to load file packages, which embeds the files into the binary and precludes caching and re-use of the package.
Partially fixes #22003, only applies to file packages.