Fix html5 events, broken by recent EM_BOOL change #22201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was broken by emscripten-core#22157 Fixes: emscripten-core#22197
sbc100
changed the title
|
Can you add a description about what was wrong and what the change does? |
Done. |
dschuff
approved these changes
Jul 8, 2024
|
Can we add a test for this? |
That sounds great, but i'm not really sure how to. I'll take a quick look. |
|
#22204 improves support for faking key events. I'll followup with a test for this code if I can. |
verhovsky
pushed a commit
to verhovsky/emscripten
that referenced
this pull request
Jul 30, 2024
) This was broken by emscripten-core#22157 Fixes: emscripten-core#22197
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #22157 I updated these fields to be 8-bit instead of 32-bit, but failed to notice that
idxitself was a pre-shifted 32-bit index (used for indexing HEAP32 specifically). This change uses the original byte-width base pointer instead of the pre-shifted pointer.Fixes: #22197