Skip to content

Conversation

@sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Sep 6, 2024

I used npm-check-update to generate this PR:

  1. npm install --global npm-check-updates
  2. ncu -u
  3. npm install

After I did this I found that eslint config file needed to be updated which forced me to run npx @eslint/migrate-config .eslintrc.yml to create the new (and less readable IMHO) config file.

@sbc100 sbc100 requested review from dschuff and kripken September 6, 2024 18:35
Copy link
Member

@dschuff dschuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but fix the title so it doesn't include 2 different PR numbers

I used npm-check-update to generate this PR:

1. npm install --global npm-check-updates
2. ncu -u
3. npm install

After I did this I found that eslint config file needed to be updated
which forced me to run `npx @eslint/migrate-config .eslintrc.yml` to
create the new (and less readable IMHO) config file.
@sbc100 sbc100 changed the title Update npm dependencies. NFC (#22122) Update npm dependencies. NFC Sep 6, 2024
@sbc100
Copy link
Collaborator Author

sbc100 commented Sep 6, 2024

I had to update the eslint config file .. see description.

@sbc100 sbc100 merged commit e7393e0 into emscripten-core:main Sep 6, 2024
1 of 2 checks passed
@sbc100 sbc100 deleted the update_npm branch September 6, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants