Use consistent helper for tests that use -sMODULARIZE #22537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
changed the title
kripken
reviewed
Sep 9, 2024
| // Avoid instantiating the module on pthreads. | ||
| if (!isPthread) | ||
| #endif | ||
| {{{ EXPORT_NAME }}}(); |
There was a problem hiding this comment.
This seems like a general thing that all users will want, but I don't have a good idea for how to provide that. We could make Module() do nothing at all on pthreads, in theory, but that seems risky, even if I can't think of a use for it.
There was a problem hiding this comment.
Yes, I thank that might make sense, but doesn't have to be part of this change. We can consider that as followup.
As part of this I also extended the `#preprocess` directive so it can be used with `--extern-pre-js` and `--extern-post-js` as well as the existing supprot for `--pre-js` and `--post-js`.
sbc100
force-pushed
the
consistent_modularized_testing
branch
from
a849bc5 to
ed9a1bd
Compare
kripken
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of this I also extended the
#preprocessdirective so it can be used with--extern-pre-jsand--extern-post-jsas well as the existing supprot for--pre-jsand--post-js.