Skip to content

[contrib.glfw3] new version 3.4.0.20240907 (bug fix) #22539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 8, 2024
Merged

[contrib.glfw3] new version 3.4.0.20240907 (bug fix) #22539

merged 1 commit into from
Sep 8, 2024

Conversation

@ypujante
Copy link
Contributor

@ypujante ypujante commented Sep 7, 2024 •
edited
Loading

Release notes:

  • Fixed Meta/Super key workaround to also handle the rare (but possible) use-case of having other keys down before pressing the Meta/Super key

@ypujante
Copy link
Contributor Author

ypujante commented Sep 7, 2024

There is only 1 test failure:

======================================================================
ERROR [61.427s]: test_offset_converter (test_browser.browser)
----------------------------------------------------------------------

which I doubt is related to my changes

@sbc100 sbc100 merged commit 1f51951 into emscripten-core:main Sep 8, 2024
1 of 2 checks passed
@dschuff dschuff mentioned this pull request Oct 29, 2024
Merged
@dschuff dschuff mentioned this pull request Nov 15, 2024
Merged
@ypujante ypujante deleted the emscripten-glfw-3.4.0.20240907 branch December 15, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbc100 sbc100 sbc100 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ypujante @sbc100